New issue
Advanced search Search tips

Issue 689420 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689428

Blocking:
issue 689410



Sign in to add a comment

Convert components/drive/drive_uploader.cc's from using PowerSaveBlocker to using Wake Lock Mojo interface

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

See parent bug.
 
Blockedon: 689428

Comment 2 by ke...@intel.com, Jun 8 2017

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a046428d63625d2c07430ab95a3f680b2f18a1

commit 24a046428d63625d2c07430ab95a3f680b2f18a1
Author: Ke He <ke.he@intel.com>
Date: Tue Jun 27 00:29:32 2017

Convert drive_uploader.cc to be client of wake lock.

Wake Lock is a Mojo interface that wraps PowerSaveBlocker. As part of the
creation of standalone Device Service, all browser-side clients of
PowerSaveBlocker should be converted to be clients of the Wake Lock Mojo
interface instead.

BUG= 689420 

Change-Id: I104e3badb41796a28d421a8d59849e546948ed3b
Reviewed-on: https://chromium-review.googlesource.com/527994
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#482487}
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/chromeos/drive/DEPS
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/chromeos/file_manager/fileapi_util_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/sync_file_system/DEPS
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/BUILD.gn
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/DEPS
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/change_list_loader_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/directory_loader_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/drive_uploader.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/drive_uploader.h
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/drive_uploader_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/file_system/operation_test_base.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/file_system_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/job_scheduler.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/job_scheduler.h
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/job_scheduler_unittest.cc
[modify] https://crrev.com/24a046428d63625d2c07430ab95a3f680b2f18a1/components/drive/sync_client_unittest.cc

Comment 4 by ke...@intel.com, Jun 29 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment