New issue
Advanced search Search tips

Issue 689415 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689428

Blocking:
issue 689410



Sign in to add a comment

Convert chrome/browser/media/cast_transport_host_filter.cc from using PowerSaveBlocker to using Wake Lock Mojo interface

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

See parent bug.
 
Blockedon: 689428
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4fe4703234db95a75f7b94d1e97044d38488156

commit b4fe4703234db95a75f7b94d1e97044d38488156
Author: ke.he <ke.he@intel.com>
Date: Thu Jun 01 03:27:58 2017

Convert CastTransportHostFilter to be client of wake lock service.

Wake Lock is a Mojo interface that wraps PowerSaveBlocker. As part of the
creation of standalone Device Service, all browser-side clients of
PowerSaveBlocker should be converted to be clients of the Wake Lock Mojo
interface instead.

BUG= 689415 

Review-Url: https://codereview.chromium.org/2891293002
Cr-Commit-Position: refs/heads/master@{#476172}

[modify] https://crrev.com/b4fe4703234db95a75f7b94d1e97044d38488156/chrome/browser/BUILD.gn
[modify] https://crrev.com/b4fe4703234db95a75f7b94d1e97044d38488156/chrome/browser/media/DEPS
[modify] https://crrev.com/b4fe4703234db95a75f7b94d1e97044d38488156/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/b4fe4703234db95a75f7b94d1e97044d38488156/chrome/browser/media/cast_transport_host_filter.h

Comment 3 by ke...@intel.com, Jun 8 2017

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea94040c26822246f57e699988b5a160fc6a3742

commit ea94040c26822246f57e699988b5a160fc6a3742
Author: Ke He <ke.he@intel.com>
Date: Wed Jul 12 04:17:46 2017

Remove the condition check on GetForProcess() in cast_transport_host_filter.

Remove the "if(ServiceManagerConnection::GetForProcess())", use the DCHECK()
instead to make sure the ServiceManagerConnection is always initialized in
production code.

BUG= 689415 

Change-Id: I85dc481a80ddbef9faa0b5c99d8da8991d4f85be
Reviewed-on: https://chromium-review.googlesource.com/545436
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#485850}
[modify] https://crrev.com/ea94040c26822246f57e699988b5a160fc6a3742/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/ea94040c26822246f57e699988b5a160fc6a3742/chrome/browser/media/cast_transport_host_filter.h
[modify] https://crrev.com/ea94040c26822246f57e699988b5a160fc6a3742/chrome/browser/media/cast_transport_host_filter_unittest.cc

Components: Internals>Services>Device

Sign in to add a comment