New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689413 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689428

Blocking:
issue 689410



Sign in to add a comment

Convert //content/browser from using PowerSaveBlocker to using Wake Lock Mojo interface

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

See parent bug.
 
Blockedon: 689428
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54f936badc7666b7b0fb09c545942836e4e9943

commit d54f936badc7666b7b0fb09c545942836e4e9943
Author: ke.he <ke.he@intel.com>
Date: Thu May 11 09:25:13 2017

Convert MediaWebContentsObsever to be the client of WakeLock mojo interface.

Convert MediaWebContentsObsever to be the client of WakeLock mojo interface
instead of direct client of PowerSaveBlocker.

TEST = Play audio or video and check the OS level wake locks.
On macOS: pmset -g assertions
On Windows: powercfg /requests.

BUG= 689413 
TBR=<jam@chromium.org>

Review-Url: https://codereview.chromium.org/2846813002
Cr-Commit-Position: refs/heads/master@{#470889}

[modify] https://crrev.com/d54f936badc7666b7b0fb09c545942836e4e9943/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/d54f936badc7666b7b0fb09c545942836e4e9943/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/d54f936badc7666b7b0fb09c545942836e4e9943/content/browser/web_contents/web_contents_impl_unittest.cc

Comment 3 by ke...@intel.com, May 19 2017

Owner: ke...@intel.com

Comment 4 by ke...@intel.com, May 19 2017

Status: Started (was: Available)

Comment 5 by ke...@intel.com, May 19 2017

Comment 16 to comment 19 in  issue 689410  should belong to this thread.
Project Member

Comment 6 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0

commit 1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0
Author: ke.he <ke.he@intel.com>
Date: Sat May 20 00:34:52 2017

Convert //content/browser/webrtc to be clients of WakeLock mojo service.

Wake Lock is a Mojo interface that wraps PowerSaveBlocker. As part of the
creation of standalone Device Service, all browser-side clients of
PowerSaveBlocker should be converted to be clients of the Wake Lock Mojo
interface instead.

This CL converts clients of PowerSaveBlocker in //content/browser/webrtc

BUG= 689413 

Review-Url: https://codereview.chromium.org/2886603003
Cr-Commit-Position: refs/heads/master@{#473395}

[modify] https://crrev.com/1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0/content/browser/webrtc/webrtc_internals_unittest.cc
[modify] https://crrev.com/1671f06ee7b3e7ba18d4a8171d3e0c64d95a44b0/content/test/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6fd56037a18d025817064d21222bc078b081428

commit f6fd56037a18d025817064d21222bc078b081428
Author: ke.he <ke.he@intel.com>
Date: Tue May 23 08:02:26 2017

Convert devtools to be client of WakeLock mojo service.

Wake Lock is a Mojo interface that wraps PowerSaveBlocker. As part of the
creation of standalone Device Service, all browser-side clients of
PowerSaveBlocker should be converted to be clients of the Wake Lock Mojo
interface instead.

BUG= 689413 

Review-Url: https://codereview.chromium.org/2893793003
Cr-Commit-Position: refs/heads/master@{#473833}

[modify] https://crrev.com/f6fd56037a18d025817064d21222bc078b081428/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/f6fd56037a18d025817064d21222bc078b081428/content/browser/devtools/render_frame_devtools_agent_host.h

Comment 8 by ke...@intel.com, Jun 8 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment