New issue
Advanced search Search tips

Issue 689394 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 687125

Blocking:
issue 612341



Sign in to add a comment

Move //device/time_zone_monitor to //services/device

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

As part of the Content Modularization Project, //device/time_zone_monitor should move to //services/device. Concretely:

- The Mojo interfaces should live in //services/device/public/interfaces
- The impl should live in //services/device/power_monitor and should be visible in GN only to //services/device. Its JNI should be registered by the Device Service rather than //content.
 

Comment 1 by leon....@intel.com, Feb 14 2017

Cc: -leon....@intel.com
Owner: leon....@intel.com
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b944ca69b3c6a3c399e93f875b627e3987813ce9

commit b944ca69b3c6a3c399e93f875b627e3987813ce9
Author: leon.han <leon.han@intel.com>
Date: Wed Feb 15 07:05:24 2017

[DeviceService] Move //device/time_zone_monitor to //services/device

This CL:
  - moves //device/time_zone_monitor/ into //services/device/,
  - lets Device Service register all necessary JNIs on its creation,
  - consolidates all java files under //services/device/ into a single target:
    //services/device:java, and keeps this target still as part of
    //content/public/android:content_java, because Device Service is embeded
    by content_browser service currently.

BUG= 689394 ,  687125 
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2690963002
Cr-Commit-Position: refs/heads/master@{#450619}

[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/content/app/BUILD.gn
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/content/app/DEPS
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/content/public/android/BUILD.gn
[delete] https://crrev.com/5e06547be990aacac4ae3ff0382d2aa222b4280a/device/time_zone_monitor/android/time_zone_monitor_jni_registrar.h
[delete] https://crrev.com/5e06547be990aacac4ae3ff0382d2aa222b4280a/device/time_zone_monitor/public/interfaces/BUILD.gn
[delete] https://crrev.com/5e06547be990aacac4ae3ff0382d2aa222b4280a/device/time_zone_monitor/public/interfaces/OWNERS
[delete] https://crrev.com/5e06547be990aacac4ae3ff0382d2aa222b4280a/device/time_zone_monitor/time_zone_monitor_export.h
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/BUILD.gn
[add] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/android/register_jni.cc
[add] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/android/register_jni.h
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/device_service.cc
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/device_service.h
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/public/interfaces/time_zone_monitor.mojom
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/BUILD.gn
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/DEPS
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/OWNERS
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/android/java/src/org/chromium/device/time_zone_monitor/TimeZoneMonitor.java
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/android/time_zone_monitor_jni_registrar.cc
[add] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/android/time_zone_monitor_jni_registrar.h
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor.cc
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor.h
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor_android.cc
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor_android.h
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor_chromeos.cc
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor_linux.cc
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor_mac.mm
[rename] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/services/device/time_zone_monitor/time_zone_monitor_win.cc
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/third_party/WebKit/Source/modules/time_zone_monitor/BUILD.gn
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/third_party/WebKit/Source/modules/time_zone_monitor/DEPS
[modify] https://crrev.com/b944ca69b3c6a3c399e93f875b627e3987813ce9/third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.h

Comment 3 by leon....@intel.com, Feb 16 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Comment 5 by laforge@google.com, Nov 7 2017

Labels: Type-Task
Migrating S13N meta bugs to Type=Task, so that they can be distinguished from technical work.

Sign in to add a comment