New issue
Advanced search Search tips

Issue 689391 link

Starred by 1 user
Status: Fixed
Owner:
leon....@intel.com
Closed: Feb 2017
Cc:
leon....@intel.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 647247



Sign in to add a comment

Move PowerMonitor interfaces, client lib, impl to live in Device Service

Project Member Reported by blundell@chromium.org, Feb 7 2017 
As part of the Content Modularization Project, //device/power_monitor should move to //services/device. Concretely:

- The Mojo interfaces should live in //services/device/public/interfaces
- The cpp lib should live in //services/device/public/cpp/power_monitor
- The impl should live in //services/device/power_monitor and should be visible in GN only to //services/device.

Comment 1 by leon....@intel.com, Feb 7 2017 

Oh, got it, thanks a lot for the summary, I'll start this soon.

Comment 2 by blundell@chromium.org, Feb 7 2017

Owner: leon....@intel.com
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b

commit 1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b
Author: leon.han <leon.han@intel.com>
Date: Thu Feb 09 04:36:24 2017

[DeviceService] Move PowerMonitor interfaces, client lib, impl to live in Device Service

This CL moves all codes of //device/power_monitor to //services/device.

BUG= 689391 
TEST=service_unittests
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2678373003
Cr-Commit-Position: refs/heads/master@{#449201}

[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/content/browser/BUILD.gn
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/content/child/BUILD.gn
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/content/child/DEPS
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/content/child/child_thread_impl.cc
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/content/common/BUILD.gn
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/device/BUILD.gn
[delete] https://crrev.com/f38739a13a880a4641302d42914d44714c0ad7dc/device/power_monitor/power_monitor_export.h
[delete] https://crrev.com/f38739a13a880a4641302d42914d44714c0ad7dc/device/power_monitor/public/interfaces/BUILD.gn
[delete] https://crrev.com/f38739a13a880a4641302d42914d44714c0ad7dc/device/power_monitor/public/interfaces/OWNERS
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/BUILD.gn
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/BUILD.gn
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/device_service.cc
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/device_service.h
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/power_monitor/BUILD.gn
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/power_monitor/OWNERS
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/power_monitor/power_monitor_message_broadcaster.cc
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/power_monitor/power_monitor_message_broadcaster.h
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/power_monitor/power_monitor_message_broadcaster_unittest.cc
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/cpp/power_monitor/BUILD.gn
[copy] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/cpp/power_monitor/OWNERS
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/cpp/power_monitor/power_monitor_broadcast_source.cc
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/cpp/power_monitor/power_monitor_broadcast_source.h
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/cpp/power_monitor/power_monitor_broadcast_source_unittest.cc
[modify] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/1b4ee5cdef50a0cd1e039f8f83d3f070e2a7a81b/services/device/public/interfaces/power_monitor.mojom

Comment 4 by leon....@intel.com, Feb 14 2017

Status: Fixed (was: Assigned)

Comment 5 by blundell@chromium.org, Nov 7 2017

Components: Internals>Services>Device

Comment 6 by laforge@google.com, Nov 7 2017

Labels: Type-Task
Migrating S13N meta bugs to Type=Task, so that they can be distinguished from technical work.
►

Sign in to add a comment