New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689390 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted vertical scrollbar is seen on md-settings page in guest mode.

Reported by yfulgaon...@etouch.net, Feb 7 2017

Issue description

Chrome Version : 58.0.3004.4 (Official Build) 54ca43feba44b861ed9986bb7d3b65d7178edd41-refs/branch-heads/3004@{#5} 32/64 bit
OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, click on 'Avatar' icon and switch to 'Guest' mode.
2. In guest mode, navigate to chrome://md-settings and type any query in 'Search box'.
3. Click on 'clear search (x)' icon in a search box and observe the vertical scrollbar at the RHS of page.

Actual : Unwanted vertical scrollbar is seen after clicking on 'Clear search' icon.
Expected : Vertical scrollbar should not appear on page, after clearing a search query.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update other info.
Good build : 56.0.2907.0
Bad build : 56.0.2908.0
 
Actual_Result.mp4
845 KB View Download
Expected_Result.mp4
674 KB View Download
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Information:
------------------------
You are probably looking for a change made after 429464 (known good), but no later than 429465 (first known bad).

CHANGELOG URL:
----------------
https://chromium.googlesource.com/chromium/src/+log/be9e1f1ffc1e1d3287c7d994587446f9d7e703ee..63797594bc2bb93e645129b0c679081dc925ba5f

From the CL above, assigning the issue to the concern owner 

@dpapad - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Friendly ping!!
Still we are able to reproduce this issue on latest Canary#58.0.3014.0.
@dpapad@, Could you please look into this & update the thread accordingly.

Thank you!!


Comment 3 by dpa...@chromium.org, Feb 17 2017

Labels: Proj-MaterialDesign-WebUI
Able to reproduce the issue on Mac 10.12.3 with chrome #58.0.3020.0

dpapad@ could you please provide an latest update on this issue.

Thank You...
Labels: Hotlist-MD-Settings-SearchBox

Comment 6 by dpa...@chromium.org, Feb 24 2017

Owner: ----
Status: Available (was: Assigned)
Marking this as Available so that others can potentially pick it up.
Able to reproduce the issue on Mac 10.12.3 with chrome #58.0.3027.3

AnyOne from dev team will provide an latest update on this issue.

Thank You...
Able to reproduce the issue on Win-10 using latest canary #59.0.3046.0.

Could anyone from dev team please have a look into this issue.

Thank You...
Cc: scottchen@chromium.org
Just did a bit of triage, the problem seems to occur whenever you go from "no results found" to a view with short search results, so not just in guest mode:

step to reproduce on non-guest mode:
1) type "search engine" somewhere on your computer and copy it with ctrl+C.
2) go to chrome:md-settings, type in search "abcdefg" and wait until it says "no results found".
3) go to the search field, ctrl+a to select all text, and ctrl+v to paste "search result" over the "abcdefg". Observe scroll-bar appears.

Seems like overscroll's padding calculation is wrong initially, but will fix itself after trying to scroll. See attached video.

overscroll miscalculation.mov
11.1 MB Download

Comment 11 Deleted

Owner: scottchen@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7253ca232d77ec26c62c72bff4d9125e37bb8c58

commit 7253ca232d77ec26c62c72bff4d9125e37bb8c58
Author: scottchen <scottchen@chromium.org>
Date: Thu Apr 20 17:45:07 2017

MD Settings: search mode shouldn't have overscrolls

BUG= 689390 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2832693002
Cr-Commit-Position: refs/heads/master@{#466054}

[modify] https://crrev.com/7253ca232d77ec26c62c72bff4d9125e37bb8c58/chrome/browser/resources/settings/settings_main/settings_main.js

Fixed?
Status: Fixed (was: Started)

Sign in to add a comment