New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 689384 link

Starred by 2 users
Status: Fixed
Owner:
█ ke...@intel.com
Email to this user bounced
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689383
Blocking:
issue 689382



Sign in to add a comment

Move //device/generic_sensor impl to be part of the internal implementation of the Device Service

Project Member Reported by blundell@chromium.org, Feb 7 2017 
Once all production code accesses the generic sensors code only via Mojo interfaces exported by the Device Service, the impl of those interfaces should be made part of the internal implementation of the Device Service. To that end, //device/generic_sensor should be moved to //service/device/generic_sensor and made visible in GN only to //services/device.

Note that browsertests in //content might still access this code directly. It is lower-priority to eliminate that dependency (e.g., by porting the browsertests to service tests of the Device Service)

Comment 1 by leon....@intel.com, Apr 28 2017

Owner: ke...@intel.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af8ead2f5065e32be6f8a5572c6a38004e2c8984

commit af8ead2f5065e32be6f8a5572c6a38004e2c8984
Author: ke.he <ke.he@intel.com>
Date: Sat May 13 03:54:30 2017

Create a new GN target //services/service_junit_tests, and enable it in bots.

Move junit test of //device/generic_sensor into the new created services_junit_tests.

The junit test of generic_sensor is hosted in //device:device_junit_tests,
Before moving the generic_sensor from //device to //services/device (which is
one step of "generic_sensor servicification"), We have to create a new
service_junit_tests target for //services first.

The new created services_junit_tests is enabled in bots. This part is copy from:
  "Issue 2868693002: Device: enable device_junit_tests in bots".

BUG= 689384 

Review-Url: https://codereview.chromium.org/2875573003
Cr-Commit-Position: refs/heads/master@{#471551}

[modify] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/BUILD.gn
[modify] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/device/BUILD.gn
[modify] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/services/BUILD.gn
[rename] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/services/device/generic_sensor/android/junit/src/org/chromium/device/sensors/PlatformSensorAndProviderTest.java
[modify] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/af8ead2f5065e32be6f8a5572c6a38004e2c8984/testing/buildbot/manage.py

Comment 3 by ke...@intel.com, May 19 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b5cf7f93a4b2f246d08208ccd17804856c38f6a

commit 9b5cf7f93a4b2f246d08208ccd17804856c38f6a
Author: ke.he <ke.he@intel.com>
Date: Fri May 19 11:34:41 2017

Remove the *.export.h, change the gn target 'component' to 'source_set', which makes the generic sensor to be the internal implementation of //services.

BUG= 689384 

Review-Url: https://codereview.chromium.org/2865263002
Cr-Commit-Position: refs/heads/master@{#473160}

[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/app/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/app/DEPS
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/browser/DEPS
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/browser/generic_sensor_browsertest.cc
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/public/android/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/content/test/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/device/BUILD.gn
[delete] https://crrev.com/c3a8b7831c0598f303b34495a7396f06d4760d8e/device/generic_sensor/generic_sensor_export.h
[delete] https://crrev.com/c3a8b7831c0598f303b34495a7396f06d4760d8e/device/generic_sensor/public/cpp/generic_sensor_public_export.h
[delete] https://crrev.com/c3a8b7831c0598f303b34495a7396f06d4760d8e/device/generic_sensor/public/interfaces/BUILD.gn
[delete] https://crrev.com/c3a8b7831c0598f303b34495a7396f06d4760d8e/device/generic_sensor/public/interfaces/OWNERS
[delete] https://crrev.com/c3a8b7831c0598f303b34495a7396f06d4760d8e/device/generic_sensor/public/interfaces/sensor.typemap
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/android/register_jni.cc
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/device_service.cc
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/device_service.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/BUILD.gn
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/DEPS
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/OWNERS
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/README.md
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensorProvider.java
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/android/sensors_jni_registrar.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/android/sensors_jni_registrar.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/fake_platform_sensor.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/fake_platform_sensor.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/fake_platform_sensor_provider.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/fake_platform_sensor_provider.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/generic_sensor_consts.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/linux/sensor_data_linux.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/linux/sensor_data_linux.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/linux/sensor_device_manager.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/linux/sensor_device_manager.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_accelerometer_mac.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_accelerometer_mac.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_ambient_light_mac.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_ambient_light_mac.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_android.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_android.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_linux.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_linux.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_android.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_android.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_base.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_base.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_linux.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_linux.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_mac.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_mac.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_unittest.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_win.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_provider_win.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_reader_linux.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_reader_linux.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_reader_win.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_reader_win.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_win.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/platform_sensor_win.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/sensor_impl.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/sensor_impl.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/sensor_provider_impl.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/generic_sensor/sensor_provider_impl.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/BUILD.gn
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/OWNERS
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/platform_sensor_configuration.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/platform_sensor_configuration.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/sensor_reading.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/sensor_reading.h
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/sensor_struct_traits.cc
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/cpp/generic_sensor/sensor_struct_traits.h
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/interfaces/OWNERS
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/interfaces/sensor.mojom
[add] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/interfaces/sensor.typemap
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/interfaces/sensor_provider.mojom
[rename] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/services/device/public/interfaces/typemaps.gni
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/Source/modules/sensor/BUILD.gn
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/Source/modules/sensor/DEPS
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/Source/modules/sensor/Sensor.cpp
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h
[modify] https://crrev.com/9b5cf7f93a4b2f246d08208ccd17804856c38f6a/third_party/WebKit/Source/modules/sensor/SensorProxy.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b

commit b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b
Author: treib <treib@chromium.org>
Date: Fri May 19 13:10:20 2017

Revert of Move //device/generic_sensor to be part of the internal implementation of the Device Service. (patchset #11 id:200001 of https://codereview.chromium.org/2865263002/ )

Reason for revert:
Seems to have broken GenericSensorBrowserTest.AmbientLightSensorTest:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/60103
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/40665
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/26223

Original issue's description:
> Remove the *.export.h, change the gn target 'component' to 'source_set', which makes the generic sensor to be the internal implementation of //services.
>
> BUG= 689384 
>
> Review-Url: https://codereview.chromium.org/2865263002
> Cr-Commit-Position: refs/heads/master@{#473160}
> Committed: https://chromium.googlesource.com/chromium/src/+/9b5cf7f93a4b2f246d08208ccd17804856c38f6a

TBR=rockot@chromium.org,blundell@chromium.org,jam@chromium.org,alexander.shalamov@intel.com,tsepez@chromium.org,reillyg@chromium.org,ke.he@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 689384 

Review-Url: https://codereview.chromium.org/2898433002
Cr-Commit-Position: refs/heads/master@{#473172}

[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/app/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/app/DEPS
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/browser/DEPS
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/browser/generic_sensor_browsertest.cc
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/public/android/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/content/test/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/BUILD.gn
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/BUILD.gn
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/DEPS
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/OWNERS
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/README.md
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensorProvider.java
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/android/sensors_jni_registrar.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/android/sensors_jni_registrar.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/fake_platform_sensor.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/fake_platform_sensor.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/fake_platform_sensor_provider.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/fake_platform_sensor_provider.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/generic_sensor_consts.h
[add] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/generic_sensor_export.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/linux/sensor_data_linux.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/linux/sensor_data_linux.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/linux/sensor_device_manager.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/linux/sensor_device_manager.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_accelerometer_mac.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_accelerometer_mac.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_ambient_light_mac.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_ambient_light_mac.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_android.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_android.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_linux.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_linux.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_android.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_android.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_base.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_base.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_linux.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_linux.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_mac.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_mac.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_unittest.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_win.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_provider_win.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_reader_linux.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_reader_linux.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_reader_win.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_reader_win.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_win.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/platform_sensor_win.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/BUILD.gn
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/OWNERS
[add] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/generic_sensor_public_export.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/platform_sensor_configuration.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/platform_sensor_configuration.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/sensor_reading.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/sensor_reading.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/sensor_struct_traits.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/cpp/sensor_struct_traits.h
[add] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/interfaces/BUILD.gn
[add] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/interfaces/OWNERS
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/interfaces/sensor.mojom
[add] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/interfaces/sensor.typemap
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/interfaces/sensor_provider.mojom
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/public/interfaces/typemaps.gni
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/sensor_impl.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/sensor_impl.h
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/sensor_provider_impl.cc
[rename] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/device/generic_sensor/sensor_provider_impl.h
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/device/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/device/android/register_jni.cc
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/device/device_service.cc
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/device/device_service.h
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/services/device/public/interfaces/OWNERS
[delete] https://crrev.com/ab6a896a5431f19e96cbc15ce7920730ac4ace51/services/device/public/interfaces/sensor.typemap
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/Source/modules/sensor/BUILD.gn
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/Source/modules/sensor/DEPS
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/Source/modules/sensor/Sensor.cpp
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h
[modify] https://crrev.com/b6fa2c513e2b0f9275b13fa48eda48c5351d6c1b/third_party/WebKit/Source/modules/sensor/SensorProxy.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15092e9195954cbc331cd58e344d0895fe03d0cd

commit 15092e9195954cbc331cd58e344d0895fe03d0cd
Author: Ke He <ke.he@intel.com>
Date: Wed Jun 14 03:09:47 2017

Rewrite the generic sensor browsertest.

As the //device/generic_sensor will be moved into //services/device and be as
an internal part of it, generic_sensor_browsertest which is in //content should
not depend on the non-public part of //services/.

So we rewrite the generic_sensor_browsertest based on the new infra. It
only depends on the public stuff of the generic_sensor now.

BUG= 689384 

Change-Id: I169e3e013509026c77a38358f56fc5f73312d3a8
Reviewed-on: https://chromium-review.googlesource.com/526291
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#479270}
[modify] https://crrev.com/15092e9195954cbc331cd58e344d0895fe03d0cd/content/browser/DEPS
[modify] https://crrev.com/15092e9195954cbc331cd58e344d0895fe03d0cd/content/browser/generic_sensor_browsertest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/607182933581c9810c99abd4e3d41b59352b5b18

commit 607182933581c9810c99abd4e3d41b59352b5b18
Author: Ke He <ke.he@intel.com>
Date: Thu Jul 06 04:08:11 2017

Reland: Move generic_sensor into Device Service.

Reland the CL: https://codereview.chromium.org/2865263002/
Move //device/generic_sensor to be part of the internal implementation
of the Device Service.

This is the last step of "Content Modularization of generic sensor". 
Remove the *.export.h, change the gn target 'component' to 'source_set', which
makes the generic sensor to be the internal implementation of //services.

Previously it broke the generic_sensor_browsertest, the root cause is: There
is a global var: |g_provider_for_testing| in "platform_sensor_provider.cc".
If we change the "component" to "source_set", all dependents don't share the
same |g_provider_for_testing| anymore.

The CL "rewrite the generic_sensor_browsertest" was landed, the new
generic_sensor_browsertest doesn't use the |g_provider_for_testing| anymore.

Compared to the reverted CL, This CL doesn't make other changes except:
1)resolving some conflicts.
2)Add visibility control in BUILD.gn of //services/device/generic_sensor.

BUG= 689384 

Change-Id: I0c989eb98e2eb8f8bf06b13e19055903b2853fd0
Reviewed-on: https://chromium-review.googlesource.com/549481
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484462}
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/chrome/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/app/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/app/DEPS
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/app/android/library_loader_hooks.cc
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/browser/DEPS
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/browser/generic_sensor_browsertest.cc
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/public/android/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/shell/android/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/content/test/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/device/BUILD.gn
[delete] https://crrev.com/3a50e365d5ebd4f5451987cc928ca3c92de8f638/device/generic_sensor/generic_sensor_export.h
[delete] https://crrev.com/3a50e365d5ebd4f5451987cc928ca3c92de8f638/device/generic_sensor/public/cpp/generic_sensor_public_export.h
[delete] https://crrev.com/3a50e365d5ebd4f5451987cc928ca3c92de8f638/device/generic_sensor/public/interfaces/BUILD.gn
[delete] https://crrev.com/3a50e365d5ebd4f5451987cc928ca3c92de8f638/device/generic_sensor/public/interfaces/OWNERS
[delete] https://crrev.com/3a50e365d5ebd4f5451987cc928ca3c92de8f638/device/generic_sensor/public/interfaces/sensor.typemap
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/android/register_jni.cc
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/device_service.cc
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/device_service.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/BUILD.gn
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/DEPS
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/OWNERS
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/README.md
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensor.java
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/android/java/src/org/chromium/device/sensors/PlatformSensorProvider.java
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/android/sensors_jni_registrar.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/android/sensors_jni_registrar.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/generic_sensor_consts.h
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/generic_sensor_service_unittest.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/linux/sensor_data_linux.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/linux/sensor_data_linux.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/linux/sensor_device_manager.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/linux/sensor_device_manager.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_accelerometer_mac.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_accelerometer_mac.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_ambient_light_mac.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_ambient_light_mac.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_android.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_android.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_linux.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_linux.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_android.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_android.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_base.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_base.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_linux.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_linux.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_mac.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_mac.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_win.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_provider_win.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_reader_linux.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_reader_linux.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_reader_win.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_reader_win.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_win.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/platform_sensor_win.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/sensor_impl.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/sensor_impl.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/sensor_provider_impl.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/generic_sensor/sensor_provider_impl.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/BUILD.gn
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/OWNERS
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/platform_sensor_configuration.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/platform_sensor_configuration.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/sensor_reading.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/sensor_reading.h
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/sensor_struct_traits.cc
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/cpp/generic_sensor/sensor_struct_traits.h
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/interfaces/OWNERS
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/interfaces/sensor.mojom
[add] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/interfaces/sensor.typemap
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/interfaces/sensor_provider.mojom
[rename] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/services/device/public/interfaces/typemaps.gni
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/Source/modules/sensor/BUILD.gn
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/Source/modules/sensor/DEPS
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/Source/modules/sensor/Sensor.cpp
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h
[modify] https://crrev.com/607182933581c9810c99abd4e3d41b59352b5b18/third_party/WebKit/Source/modules/sensor/SensorProxy.h

Comment 8 by ke...@intel.com, Jul 6 2017

Status: Fixed (was: Started)

Comment 9 by blundell@chromium.org, Nov 7 2017

Components: Internals>Services>Device
►

Sign in to add a comment