Note that as part of (or immediately after) the port of the hosting, the Mojo interfaces themselves should be moved from //device/generic_sensor to //services/device/public/interfaces.
Blink's layout tests mock the generic sensors impl client-side in JS, so this is blocked from landing until crbug.com/689385 is fixed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a91facddec70d3f7bd95075eb9f15fa892572d18 commit a91facddec70d3f7bd95075eb9f15fa892572d18 Author: ke.he <ke.he@intel.com> Date: Wed Apr 12 05:11:50 2017 Port device_generic_sensor to be hosted in Device Service. Generic_sensor is currently hosted in RenderFrameHostImpl, this CL move it to be hosted in Device Service. The exsiting dependencies from //content/ to //device/generic_sensors are: 1) Generic_sensor_browsertest. I will replace browsertest by a device service test in next CL. 2) JNI registry and APK packaging. It is easy to remove those deps when moving //device/generic_sensor files into //service/device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG= 689383 Review-Url: https://codereview.chromium.org/2698083007 Cr-Commit-Position: refs/heads/master@{#463934} [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/chrome/browser/BUILD.gn [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/chrome/browser/DEPS [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/chrome/browser/about_flags.cc [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/browser/BUILD.gn [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/child/BUILD.gn [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/child/DEPS [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/child/runtime_features.cc [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/public/common/content_features.cc [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/content/public/common/content_features.h [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/BUILD.gn [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/device_service.cc [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/device_service.h [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/manifest.json [add] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/public/cpp/BUILD.gn [add] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/public/cpp/device_features.cc [add] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/services/device/public/cpp/device_features.h [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/third_party/WebKit/Source/modules/sensor/BUILD.gn [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/third_party/WebKit/Source/modules/sensor/DEPS [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp [modify] https://crrev.com/a91facddec70d3f7bd95075eb9f15fa892572d18/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h
Comment 1 by blundell@chromium.org
, Feb 7 2017