Move VibrationManagerImplTest.java from //content into //device |
||||||
Issue descriptionThe VibrationManagerImpl.java is in //device while the VibrationManagerImplTest.java is still in //content. VibrationManagerImplTest.java has dependency on content layer and not so straightforward to decouple.
,
Feb 16 2017
VibrationManagerImplTest.java does not blocking our work to move vibration into //services/device. - VibrationManagerImplTest extends ContentShellTestBase to launch html&js inside content shell to execute 'navigator.vibrate()', this is really testing impl of VibrationManagerImpl. -- Can't be moved out of //content/. - It calls static function VibrationManagerImpl.setVibratorWrapperForTesting() to inject a fake VibrationManagerImpl.AndroidVibratorWrapper to take over all mojo calls from VibrationManagerImpl, so no need to get the real VibrationManagerImpl instance. -- Even VibrationManager interface is hosted in Device Service in future, this still works. - It is included in content_shell_test_apk. -- All java files will still be packaged into content_java, so this still works even VibrationManagerImpl.java is moved into //services/device/ in future.
,
Feb 20 2017
Thanks for the analysis, Han Leon! We should eliminate the direct code dependencies that //content has on the implementation of the Device Service (e.g., the call of VibrationManagerImpl.setVibratorWrapperForTesting()). I suggest that we change this test to a service test that lives within the Device Service: - Abstract the usage of a webpage that calls the vibration web API with connecting to a Mojo service that itself connects to the Device Service to get the vibration interface and then makes calls on that vibration interface. The renderer-side testing that the usage of the vibration web API results in the corresponding Mojo call would be covered by the layout test that you mentioned here: https://bugs.chromium.org/p/chromium/issues/detail?id=686692#c3. Does that make sense?
,
Mar 13 2017
After investigation I think now I've mastered how to write a service test which would be enough to test the interface impl(VibrationManagerImpl), later I'll do this work alongside moving all vibration codes from //device into //services/device. Thank you!
,
Mar 13 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c17bee62f1e16224fabb7c83bbeaab719015761 commit 9c17bee62f1e16224fabb7c83bbeaab719015761 Author: leon.han <leon.han@intel.com> Date: Tue Apr 11 13:47:35 2017 [DeviceService] Add service tests for VibrationManager. VibrationManagerImpl.java is in //device/vibration while the VibrationManagerImplTest.java is still in //content, to be able to hide all //device/vibration impl inside Device Service, we must eliminate this concrete dependency on //device/vibration from content layer. As VibrationManagerImplTest.java is an integration test based on content shell test infra, we can't move it outside of //content. So we consider to use other tests to replace it, while the renderer-side testing has already been covered by layout tests created at https://codereview.chromium.org/2731953003/, so we create this CL to cover the VibrationManager interface impl testing: - creates an infra for Device Service service tests. - adds a new service test for VibrationManager interface. Then after this CL we'll be able to hide all vibration impl inside Device Service with a follow-up CL. BUG= 689379 TEST=service_unittests Review-Url: https://codereview.chromium.org/2774783003 Cr-Commit-Position: refs/heads/master@{#463612} [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/content/public/android/BUILD.gn [delete] https://crrev.com/5f11985eb39f27ae2a405dde3d964d2ab02bb992/content/public/android/javatests/src/org/chromium/content/browser/VibrationManagerImplTest.java [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/device/vibration/android/BUILD.gn [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/device/vibration/vibration_manager_impl.h [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/device/vibration/vibration_manager_impl_default.cc [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/BUILD.gn [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/device/BUILD.gn [add] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/device/device_service_test_base.cc [add] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/device/device_service_test_base.h [add] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/device/unittest_manifest.json [add] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/device/vibration/vibration_manager_impl_unittest.cc [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/service_manager/public/cpp/test/BUILD.gn [modify] https://crrev.com/9c17bee62f1e16224fabb7c83bbeaab719015761/services/service_manager/public/cpp/test/run_all_service_tests.cc
,
Apr 11 2017
,
Apr 11 2017
This appears to be the culprit of a failure in service_unittests running on a Nexus 5X build bot. Going to revert. Please work with Ken to fix and reland this patch. I 24.008s list_tests(00e2183927979603) No tests found. Output: I 24.008s TimeoutThread-1-for-delete_temporary_file(00e2183927979603) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00e2183927979603 shell 'rm -f /sdcard/temp_file-7985ce1f36d3e.gtest_out' I 24.008s list_tests(00e2183927979603) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.008s list_tests(00e2183927979603) #00 0x0000007f84e832cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.010s list_tests(00e2183927979603) #01 0x0000007f84e662ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.010s list_tests(00e2183927979603) #02 0x0000007f84e664e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.011s TimeoutThread-1-for-list_tests(00bba6248fe73e2b) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00bba6248fe73e2b pull /data/local/tmp/temp_file-49e551ac098d3 /b/swarm_slave/w/itSNAp02/tmpG_NzMH/tmp_ReadFileWithPull I 24.011s list_tests(00e2183927979603) #03 0x0000007f85da758f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.012s list_tests(00e2183927979603) #04 0x0000007f84e67427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.013s list_tests(00e2183927979603) #05 0x0000007f84e454bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.013s list_tests(00e2183927979603) #06 0x0000007f85da80c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.013s list_tests(00e2183927979603) #07 0x0000007f85da81b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.013s list_tests(00e2183927979603) #08 0x0000007f8795653b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.013s list_tests(00e2183927979603) I 24.013s list_tests(00e2183927979603) [ CRASHED ] I 24.014s TimeoutThread-1-for-list_tests(00a9a2b496ad3158) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00a9a2b496ad3158 shell '( cat /sdcard/temp_file-7d89f64f0dcc0.gtest_out );echo %$?' I 24.019s TimeoutThread-1-for-list_tests(004903e8e2d0c42e) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 004903e8e2d0c42e shell '( TZ=utc ls -a -l /sdcard/ );echo %$?' I 24.024s TimeoutThread-1-for-list_tests(009284ab96f53754) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 009284ab96f53754 shell '( cat /sdcard/temp_file-9b3769c5d7d5.gtest_out );echo %$?' I 24.029s TimeoutThread-1-for-delete_temporary_file(00c6fc067e670fce) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00c6fc067e670fce shell 'rm -f /data/local/tmp/temp_file-d2017d76bc3c7' I 24.032s list_tests(00a9a2b496ad3158) No tests found. Output: I 24.032s list_tests(00a9a2b496ad3158) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.033s TimeoutThread-1-for-delete_temporary_file(00a9a2b496ad3158) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00a9a2b496ad3158 shell 'rm -f /sdcard/temp_file-7d89f64f0dcc0.gtest_out' I 24.033s list_tests(00a9a2b496ad3158) #00 0x0000007f6b92b2cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.033s list_tests(00a9a2b496ad3158) #01 0x0000007f6b90e2ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.033s list_tests(00a9a2b496ad3158) #02 0x0000007f6b90e4e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.033s list_tests(00a9a2b496ad3158) #03 0x0000007f6c84f58f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.033s list_tests(00a9a2b496ad3158) #04 0x0000007f6b90f427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.033s list_tests(00a9a2b496ad3158) #05 0x0000007f6b8ed4bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.033s list_tests(00a9a2b496ad3158) #06 0x0000007f6c8500c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.033s list_tests(00a9a2b496ad3158) #07 0x0000007f6c8501b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.033s list_tests(00a9a2b496ad3158) #08 0x0000007f6e3fe53b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.034s list_tests(00a9a2b496ad3158) I 24.034s list_tests(00a9a2b496ad3158) [ CRASHED ] I 24.035s TimeoutThread-1-for-list_tests(00c6fc067e670fce) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00c6fc067e670fce shell '( TZ=utc ls -a -l /sdcard/ );echo %$?' I 24.037s TimeoutThread-1-for-list_tests(00d78f7d49b9300e) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00d78f7d49b9300e shell '( cat /sdcard/temp_file-392206929895e.gtest_out );echo %$?' I 24.043s list_tests(009284ab96f53754) No tests found. Output: I 24.043s list_tests(009284ab96f53754) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.044s list_tests(009284ab96f53754) #00 0x0000007f6fc2b2cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.044s list_tests(009284ab96f53754) #01 0x0000007f6fc0e2ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.044s list_tests(009284ab96f53754) #02 0x0000007f6fc0e4e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.044s TimeoutThread-1-for-delete_temporary_file(009284ab96f53754) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 009284ab96f53754 shell 'rm -f /sdcard/temp_file-9b3769c5d7d5.gtest_out' I 24.044s list_tests(009284ab96f53754) #03 0x0000007f70b4f58f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.044s list_tests(009284ab96f53754) #04 0x0000007f6fc0f427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.044s list_tests(009284ab96f53754) #05 0x0000007f6fbed4bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.044s list_tests(009284ab96f53754) #06 0x0000007f70b500c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.044s list_tests(009284ab96f53754) #07 0x0000007f70b501b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.044s list_tests(009284ab96f53754) #08 0x0000007f726fe53b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.044s list_tests(009284ab96f53754) I 24.044s list_tests(009284ab96f53754) [ CRASHED ] I 24.061s TimeoutThread-1-for-delete_temporary_file(00bba6248fe73e2b) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00bba6248fe73e2b shell 'rm -f /data/local/tmp/temp_file-49e551ac098d3' I 24.065s TimeoutThread-1-for-list_tests(004903e8e2d0c42e) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 004903e8e2d0c42e shell '( cat /sdcard/temp_file-68b0fdf7e4d3.gtest_out );echo %$?' I 24.070s TimeoutThread-1-for-list_tests(00bba6248fe73e2b) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00bba6248fe73e2b shell '( TZ=utc ls -a -l /sdcard/ );echo %$?' I 24.090s TimeoutThread-1-for-list_tests(00c6fc067e670fce) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00c6fc067e670fce shell '( cat /sdcard/temp_file-ae139ca98a063.gtest_out );echo %$?' I 24.091s list_tests(00d78f7d49b9300e) No tests found. Output: I 24.091s list_tests(00d78f7d49b9300e) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.092s TimeoutThread-1-for-delete_temporary_file(00d78f7d49b9300e) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00d78f7d49b9300e shell 'rm -f /sdcard/temp_file-392206929895e.gtest_out' I 24.092s list_tests(00d78f7d49b9300e) #00 0x0000007f8b46b2cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.093s list_tests(00d78f7d49b9300e) #01 0x0000007f8b44e2ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.093s list_tests(00d78f7d49b9300e) #02 0x0000007f8b44e4e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.094s list_tests(00d78f7d49b9300e) #03 0x0000007f8c38f58f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.095s list_tests(00d78f7d49b9300e) #04 0x0000007f8b44f427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.095s list_tests(00d78f7d49b9300e) #05 0x0000007f8b42d4bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.095s list_tests(00d78f7d49b9300e) #06 0x0000007f8c3900c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.095s list_tests(00d78f7d49b9300e) #07 0x0000007f8c3901b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.095s list_tests(00d78f7d49b9300e) #08 0x0000007f8df3e53b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.095s list_tests(00d78f7d49b9300e) I 24.096s list_tests(00d78f7d49b9300e) [ CRASHED ] I 24.119s list_tests(004903e8e2d0c42e) No tests found. Output: I 24.119s TimeoutThread-1-for-delete_temporary_file(004903e8e2d0c42e) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 004903e8e2d0c42e shell 'rm -f /sdcard/temp_file-68b0fdf7e4d3.gtest_out' I 24.120s list_tests(004903e8e2d0c42e) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.120s list_tests(004903e8e2d0c42e) #00 0x0000007f6e1212cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.120s list_tests(004903e8e2d0c42e) #01 0x0000007f6e1042ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.121s list_tests(004903e8e2d0c42e) #02 0x0000007f6e1044e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.121s list_tests(004903e8e2d0c42e) #03 0x0000007f6f04558f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.121s list_tests(004903e8e2d0c42e) #04 0x0000007f6e105427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.121s list_tests(004903e8e2d0c42e) #05 0x0000007f6e0e34bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.121s list_tests(004903e8e2d0c42e) #06 0x0000007f6f0460c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.121s list_tests(004903e8e2d0c42e) #07 0x0000007f6f0461b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.121s list_tests(004903e8e2d0c42e) #08 0x0000007f70bf453b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.121s list_tests(004903e8e2d0c42e) I 24.121s list_tests(004903e8e2d0c42e) [ CRASHED ] I 24.122s TimeoutThread-1-for-list_tests(00bba6248fe73e2b) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00bba6248fe73e2b shell '( cat /sdcard/temp_file-e4d2f5972127b.gtest_out );echo %$?' I 24.137s TimeoutThread-1-for-delete_temporary_file(00c6fc067e670fce) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00c6fc067e670fce shell 'rm -f /sdcard/temp_file-ae139ca98a063.gtest_out' I 24.140s list_tests(00c6fc067e670fce) No tests found. Output: I 24.140s list_tests(00c6fc067e670fce) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.142s list_tests(00c6fc067e670fce) #00 0x0000007f8de212cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.142s list_tests(00c6fc067e670fce) #01 0x0000007f8de042ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.142s list_tests(00c6fc067e670fce) #02 0x0000007f8de044e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.142s list_tests(00c6fc067e670fce) #03 0x0000007f8ed4558f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.142s list_tests(00c6fc067e670fce) #04 0x0000007f8de05427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.142s list_tests(00c6fc067e670fce) #05 0x0000007f8dde34bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.142s list_tests(00c6fc067e670fce) #06 0x0000007f8ed460c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.142s list_tests(00c6fc067e670fce) #07 0x0000007f8ed461b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.142s list_tests(00c6fc067e670fce) #08 0x0000007f908f453b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.143s list_tests(00c6fc067e670fce) I 24.143s list_tests(00c6fc067e670fce) [ CRASHED ] I 24.172s TimeoutThread-1-for-delete_temporary_file(00bba6248fe73e2b) [host]> /b/swarm_slave/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 00bba6248fe73e2b shell 'rm -f /sdcard/temp_file-e4d2f5972127b.gtest_out' I 24.172s list_tests(00bba6248fe73e2b) No tests found. Output: I 24.173s list_tests(00bba6248fe73e2b) [FATAL:jni_android.cc(130)] Failed to find class org/chromium/mojo/system/impl/CoreImpl I 24.175s list_tests(00bba6248fe73e2b) #00 0x0000007f68acf2cf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004cf2cf I 24.176s list_tests(00bba6248fe73e2b) #01 0x0000007f68ab22ab /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b22ab I 24.176s list_tests(00bba6248fe73e2b) #02 0x0000007f68ab24e7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b24e7 I 24.176s list_tests(00bba6248fe73e2b) #03 0x0000007f699f358f /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f358f I 24.176s list_tests(00bba6248fe73e2b) #04 0x0000007f68ab3427 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004b3427 I 24.176s list_tests(00bba6248fe73e2b) #05 0x0000007f68a914bf /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000004914bf I 24.176s list_tests(00bba6248fe73e2b) #06 0x0000007f699f40c7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f40c7 I 24.176s list_tests(00bba6248fe73e2b) #07 0x0000007f699f41b7 /data/app/org.chromium.native_test-1/lib/arm64/lib_service_unittests__library.so+0x00000000013f41b7 I 24.176s list_tests(00bba6248fe73e2b) #08 0x0000007f6b5a253b /data/app/org.chromium.native_test-1/oat/arm64/base.odex+0x00000000004c653b I 24.177s list_tests(00bba6248fe73e2b) I 24.177s list_tests(00bba6248fe73e2b) [ CRASHED ] I 24.206s tear_down_device(004903e8e2d0c42e) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_004903e8e2d0c42e.json I 24.209s tear_down_device(009284ab96f53754) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_009284ab96f53754.json I 24.210s tear_down_device(00a9a2b496ad3158) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_00a9a2b496ad3158.json I 24.210s tear_down_device(00bba6248fe73e2b) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_00bba6248fe73e2b.json I 24.211s tear_down_device(00e2183927979603) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_00e2183927979603.json I 24.212s tear_down_device(00c6fc067e670fce) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_00c6fc067e670fce.json I 24.212s tear_down_device(00d78f7d49b9300e) Wrote device cache: /b/swarm_slave/w/ir/out/Release/device_cache_00d78f7d49b9300e.json I 32.788s Main Opening text logdog stream, unified_logcats I 32.789s Main Getting logdog client. C 32.794s Main Logcat: https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F357628cf84a6c511%2F%2B%2Funified_logcats E 32.796s Main Error occurred. Traceback (most recent call last): File "/b/swarm_slave/w/ir/build/android/test_runner.py", line 913, in main return RunTestsCommand(args) File "/b/swarm_slave/w/ir/build/android/test_runner.py", line 672, in RunTestsCommand return RunTestsInPlatformMode(args) File "/b/swarm_slave/w/ir/build/android/test_runner.py", line 785, in RunTestsInPlatformMode raw_results = test_run.RunTests() File "/b/swarm_slave/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 76, in RunTests tests = self._GetTests() File "/b/swarm_slave/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 373, in _GetTests 'Failed to list tests on any device') CommandFailedError: Failed to list tests on any device [E2017-04-11T07:08:31.389878-07:00 17851 0 subcommand_run.go:333] Command completed with non-zero return code. {"returnCode":1} [I2017-04-11T07:08:31.502883-07:00 17851 0 main.go:349] Terminating. {"returnCode":1} +---------------------------------------------------------------------------+ | End of shard 0 Pending: 6.5s Duration: 33.7s Bot: build301-m4 Exit: 1 | +---------------------------------------------------------------------------+ Total duration: 33.7s WARNING:root:collect_cmd had non-zero return code: 1 step returned non-zero exit code: 1
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37 commit 1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37 Author: rouslan <rouslan@chromium.org> Date: Tue Apr 11 14:46:43 2017 Revert of [DeviceService] Add service tests for VibrationManager. (patchset #7 id:410001 of https://codereview.chromium.org/2774783003/ ) Reason for revert: Appears to have broken service_unittests on Nexus 5X. Original issue's description: > [DeviceService] Add service tests for VibrationManager. > > VibrationManagerImpl.java is in //device/vibration while the > VibrationManagerImplTest.java is still in //content, > to be able to hide all //device/vibration impl inside Device Service, > we must eliminate this concrete dependency on //device/vibration from > content layer. > > As VibrationManagerImplTest.java is an integration test based on > content shell test infra, we can't move it outside of //content. > So we consider to use other tests to replace it, while the renderer-side > testing has already been covered by layout tests created at > https://codereview.chromium.org/2731953003/, so we create this CL to > cover the VibrationManager interface impl testing: > - creates an infra for Device Service service tests. > - adds a new service test for VibrationManager interface. > > Then after this CL we'll be able to hide all vibration impl inside > Device Service with a follow-up CL. > > BUG= 689379 > TEST=service_unittests > > Review-Url: https://codereview.chromium.org/2774783003 > Cr-Commit-Position: refs/heads/master@{#463612} > Committed: https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbeaab719015761 TBR=rockot@chromium.org,avi@chromium.org,blundell@chromium.org,jam@chromium.org,timvolodine@chromium.org,leon.han@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 689379 Review-Url: https://codereview.chromium.org/2815623003 Cr-Commit-Position: refs/heads/master@{#463629} [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/content/public/android/BUILD.gn [add] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/content/public/android/javatests/src/org/chromium/content/browser/VibrationManagerImplTest.java [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/device/vibration/android/BUILD.gn [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/device/vibration/vibration_manager_impl.h [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/device/vibration/vibration_manager_impl_default.cc [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/services/BUILD.gn [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/services/device/BUILD.gn [delete] https://crrev.com/4d28782bf7d3eb161b9f6ec796a041271633d8b2/services/device/device_service_test_base.cc [delete] https://crrev.com/4d28782bf7d3eb161b9f6ec796a041271633d8b2/services/device/device_service_test_base.h [delete] https://crrev.com/4d28782bf7d3eb161b9f6ec796a041271633d8b2/services/device/unittest_manifest.json [delete] https://crrev.com/4d28782bf7d3eb161b9f6ec796a041271633d8b2/services/device/vibration/vibration_manager_impl_unittest.cc [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/services/service_manager/public/cpp/test/BUILD.gn [modify] https://crrev.com/1a5a2cdc76662f6e8fa8bb70ee9ab29a78c6ab37/services/service_manager/public/cpp/test/run_all_service_tests.cc
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70adfd46aefb86021a640567bdc07d6b6c73a066 commit 70adfd46aefb86021a640567bdc07d6b6c73a066 Author: leon.han <leon.han@intel.com> Date: Wed Apr 12 03:14:12 2017 Reland - [DeviceService] Add service tests for VibrationManager. Original CL was reverted because it appears to have broken service_unittests on Nexus 5X. This CL fixes it and relands. VibrationManagerImpl.java is in //device/vibration while the VibrationManagerImplTest.java is still in //content, to be able to hide all //device/vibration impl inside Device Service, we must eliminate this concrete dependency on //device/vibration from content layer. As VibrationManagerImplTest.java is an integration test based on content shell test infra, we can't move it outside of //content. So we consider to use other tests to replace it, while the renderer-side testing has already been covered by layout tests created at https://codereview.chromium.org/2731953003/, so we create this CL to cover the VibrationManager interface impl testing: - creates an infra for Device Service service tests. - adds a new service test for VibrationManager interface. Then after this CL we'll be able to hide all vibration impl inside Device Service with a follow-up CL. BUG= 689379 TEST=service_unittests TBR=avi@chromium.org Review-Url: https://codereview.chromium.org/2774783003 Cr-Original-Commit-Position: refs/heads/master@{#463612} Committed: https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbeaab719015761 Review-Url: https://codereview.chromium.org/2814013002 Cr-Commit-Position: refs/heads/master@{#463915} [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/content/public/android/BUILD.gn [delete] https://crrev.com/9589ae21cd500f7e62833fd54392127902a7d004/content/public/android/javatests/src/org/chromium/content/browser/VibrationManagerImplTest.java [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/device/vibration/android/BUILD.gn [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/device/vibration/android/java/src/org/chromium/device/vibration/VibrationManagerImpl.java [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/device/vibration/vibration_manager_impl.h [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/device/vibration/vibration_manager_impl_default.cc [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/BUILD.gn [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/device/BUILD.gn [add] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/device/device_service_test_base.cc [add] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/device/device_service_test_base.h [add] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/device/unittest_manifest.json [add] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/device/vibration/vibration_manager_impl_unittest.cc [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/service_manager/public/cpp/test/BUILD.gn [modify] https://crrev.com/70adfd46aefb86021a640567bdc07d6b6c73a066/services/service_manager/public/cpp/test/run_all_service_tests.cc
,
Apr 26 2017
,
Nov 7 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by leon....@intel.com
, Feb 15 2017Owner: leon....@intel.com
Status: Assigned (was: Untriaged)