vboot_reference: gen_test_cases.sh does not generate correct signatures anymore |
|||||||
Issue descriptionIn order to add RSA exponent 3 support, I need to regenerate keys and signatures. However, it seems like I cannot regenerate the signatures anymore. In src/platform/vboot_reference: 1. Cherry-pick https://chromium-review.googlesource.com/439064 (this adds make gentestcases target, and prevents test_file from being regenerated if it already exists). 2. make runtests => All tests pass 3. make gentestcases At this point, git status should show no change (test_file has not changed, nor the keys), but all the signatures have now changed (and are incorrect): Changes not staged for commit: modified: tests/testcases/test_file.rsa1024_sha1.sig ... modified: tests/testcases/test_file.rsa8192_sha512.sig And now, make runtests fails: tests/vb2_rsa_tests.sh Testing signature verification... For RSA-1024 and sha1: Signature Verification FAILED
,
Feb 8 2017
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/0bde10afbfa8753521b1d10d89b5409d4d1ad1f2 commit 0bde10afbfa8753521b1d10d89b5409d4d1ad1f2 Author: Nicolas Boichat <drinkcat@google.com> Date: Sat Feb 11 10:42:01 2017 signature_digest/SignatureDigest: convert vb2_crypto to hash algorithm We were passing the wrong value to PrependDigestInfo. Let's also refactor the function a little bit. BRANCH=none BUG= chromium:689371 TEST=make gentestcases; git status => no change Change-Id: I0244c3f3de05b33b7ddd21e93a266faf34f2c239 Reviewed-on: https://chromium-review.googlesource.com/439086 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/0bde10afbfa8753521b1d10d89b5409d4d1ad1f2/host/lib/signature_digest.c
,
Feb 13 2017
Fixed. I can't find any uses of signature_digest_utility in our code, expect for that specific case generation shell script, so I believe this bug had no impact.
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by drinkcat@chromium.org
, Feb 7 2017