Issue metadata
Sign in to add a comment
|
Regression:unwanted space is displaying while scrolling down in mange search engines page. |
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3004.4 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and zoom to 110% (2)Go to chrome://MD-settings and sign in to chrome with valid credentials. (3)open manage search engines page and scroll down and observe other search engines section. Expected Result: unwanted space should not be displayed while scrolling down in other search engines of manage search engines page. Actual Result: unwanted space is displaying while scrolling down in other search engines of manage search engines page. This is a regression issue broken in M56. Good Build: 56.0.2903.0 dev Bad Build: 56.0.2904.0 dev
,
Feb 7 2017
Quick triage of this issue: Issue is caused by having 2 iron lists with the same scroll target. Issue doesn't reproduce if either list doesn't need to scroll virtually. http://jsbin.com/vogegah/edit?html,output to see behavior.
,
Feb 8 2017
,
Feb 18 2017
yep. I don't think that was ever supported. Usually, the ideal thing here is to use a single list with templates of different kinds. E.g.
<iron-list>
<template>
<div hidden$="..">
</div>
<div hidden$="..">
</div>
.
.
.
</template>
</iron-list>
or use dom-repeat for this use case.
,
Feb 20 2017
,
Mar 29 2017
@hcarmona/dbeam, any thoughts on what we can do about this bug? I personally can't repro on 59.0.3051.3 canary but it's possible I'm just not hitting some edge case. Keeping as Pri-1 for M59 right now.
,
Apr 3 2017
,
Apr 4 2017
Based on conversation w/ dbeam@ we want to make the top section fixed height at 6 items because it should be relatively small. The big section will continue to use the page as the scroll target. Attached screenshots +bettes@ for UI feedback
,
Apr 7 2017
CL to enable virtual scrolling on 2nd list is landed. See: http://crrev.com/2795653007 Visual glitch can still be seen on that list when scrolling. Investigating...
,
Apr 7 2017
Works for me!
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aa395986fe5e88a8c6d867c5e6e663697c89854 commit 2aa395986fe5e88a8c6d867c5e6e663697c89854 Author: hcarmona <hcarmona@chromium.org> Date: Mon Apr 10 17:37:59 2017 MD Settings: make iron list offset so items render onscreen R=dbeam@chromium.org BUG= 689356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2805213003 Cr-Commit-Position: refs/heads/master@{#463312} [modify] https://crrev.com/2aa395986fe5e88a8c6d867c5e6e663697c89854/chrome/browser/resources/settings/search_engines_page/search_engines_list.html [modify] https://crrev.com/2aa395986fe5e88a8c6d867c5e6e663697c89854/chrome/browser/resources/settings/search_engines_page/search_engines_list.js [modify] https://crrev.com/2aa395986fe5e88a8c6d867c5e6e663697c89854/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/2aa395986fe5e88a8c6d867c5e6e663697c89854/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
,
Apr 10 2017
Last commit fixes issue w/ iron-list offset. This should be fixed now. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Feb 7 2017Labels: -Needs-Bisect hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)