goma recipe module doesn't immediately fail when goma fails to install |
|||||||
Issue descriptionSee https://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/18160 for an example. The build keeps going and ultimately fails in the 'compile' step.
,
Feb 7 2017
,
Feb 7 2017
cipd failure? https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.webrtc%2Flinux_baremetal%2F18160%2F%2B%2Frecipes%2Fsteps%2Fensure_goma%2F0%2Fsteps%2Fensure_installed%2F0%2Fstdout
,
Feb 7 2017
This is related to cit postmortem #21. This bug is in the recipe itself (the recipe SHOULD have immediately stopped, rather than continuing on to eventually fail on the compile step)
,
Feb 8 2017
Ah... looks like this is actually a bug in the goma module then :/
,
Feb 8 2017
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/6b6cc47f0e088619cb945c36e8656fab4b8c6f45 commit 6b6cc47f0e088619cb945c36e8656fab4b8c6f45 Author: Takuto Ikuta <tikuta@google.com> Date: Wed Feb 08 06:28:07 2017 Make it fatal if ensure_goma failed BUG= 689355 Change-Id: I6ca2dccca63803cfbf4ab562bfb1dc025c80948b Reviewed-on: https://chromium-review.googlesource.com/439066 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> [modify] https://crrev.com/6b6cc47f0e088619cb945c36e8656fab4b8c6f45/scripts/slave/recipe_modules/goma/api.py [modify] https://crrev.com/6b6cc47f0e088619cb945c36e8656fab4b8c6f45/scripts/slave/recipe_modules/chromium/api.py [modify] https://crrev.com/6b6cc47f0e088619cb945c36e8656fab4b8c6f45/scripts/slave/recipes/chromium.expected/ensure_goma_fail.json
,
Feb 8 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dsansome@chromium.org
, Feb 7 2017