New issue
Advanced search Search tips

Issue 689341 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up WebCache and public interface to MemoryCache

Project Member Reported by kinuko@chromium.org, Feb 7 2017

Issue description

A few possible cleanup areas:

1. WebCache should be able to be moved from web/ to platform/ now
2. web_cache components could be possibly subsumed by the memory coordinator

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed1ed1d44cdeff32f6fd210b9e72864c60402426

commit ed1ed1d44cdeff32f6fd210b9e72864c60402426
Author: kinuko <kinuko@chromium.org>
Date: Wed Feb 08 09:13:43 2017

Move WebCache from public/web into public/platform

Now that MemoryCache related files moved into platform/, this doesn't
really need to live in public/web either.

BUG= 689341 
TBR=boliu@chromioum.org

Review-Url: https://codereview.chromium.org/2675303004
Cr-Commit-Position: refs/heads/master@{#448937}

[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/android_webview/renderer/aw_render_thread_observer.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/browser/DEPS
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/browser/extensions/api/processes/processes_api.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/browser/process_resource_usage.h
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/browser/task_manager/providers/task.h
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/browser/ui/task_manager/task_manager_table_model.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/common/resource_usage_reporter_type_converters.h
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/chrome/renderer/net_benchmarking_extension.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/components/test_runner/test_interfaces.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/components/web_cache/renderer/DEPS
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/components/web_cache/renderer/web_cache_impl.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/content/test/blink_test_environment.cc
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/platform/exported/WebCache.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/ViewportTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/WebSearchableFormDataTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/Source/web/tests/sim/SimTest.cpp
[modify] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/public/BUILD.gn
[rename] https://crrev.com/ed1ed1d44cdeff32f6fd210b9e72864c60402426/third_party/WebKit/public/platform/WebCache.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/584e0be921ffc96b1b8b400dece9ed18a6af1931

commit 584e0be921ffc96b1b8b400dece9ed18a6af1931
Author: kinuko <kinuko@chromium.org>
Date: Sun Feb 12 13:03:22 2017

URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG= 689341 
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2683033005
Cr-Commit-Position: refs/heads/master@{#449891}

[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/platform/loader/fetch/FetchTestingPlatformSupport.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/ViewportTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/WebSearchableFormDataTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp
[modify] https://crrev.com/584e0be921ffc96b1b8b400dece9ed18a6af1931/third_party/WebKit/public/platform/WebURLLoaderMockFactory.h

Comment 3 by kinuko@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment