New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689336 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

uprev media-gfx/deqp to aosp master

Project Member Reported by ihf@chromium.org, Feb 7 2017

Issue description

We would like graphics_dEQP to follow 
https://android.googlesource.com/platform/external/deqp/+log/master/

instead of currently
https://android.googlesource.com/platform/external/deqp/+/android-cts-7.1_r1

For convenience I have uploaded today's tot
gs://chromeos-localmirror/distfiles/deqp-197032faf334fcee3b46c714ac40c23facddb8d8.tar.gz
but currently none of the patches in ~/trunk/src/third_party/chromiumos-overlay/media-gfx/deqp applies.

Also it would be ideal once rebased to upstream all remaining patches to aosp.
 

Comment 1 by ihf@chromium.org, Feb 23 2017

glados


glados

deqp-2017.02.22-r1: -- Configuring done
deqp-2017.02.22-r1: CMake Error at external/glslang/CMakeLists.txt:98 (add_library):
deqp-2017.02.22-r1:   Cannot find source file:
deqp-2017.02.22-r1: 
deqp-2017.02.22-r1:     /build/glados/tmp/portage/media-gfx/deqp-2017.02.22-r1/work/external/glslang/src/glslang/MachineIndependent/iomapper.cpp
deqp-2017.02.22-r1: 
deqp-2017.02.22-r1:   Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
deqp-2017.02.22-r1:   .hxx .in .txx
deqp-2017.02.22-r1: 
deqp-2017.02.22-r1: 
deqp-2017.02.22-r1: CMake Error: CMake can not determine linker language for target: glslang
deqp-2017.02.22-r1: -- Generating done
deqp-2017.02.22-r1: -- Build files have been written to: /build/glados/tmp/portage/media-gfx/deqp-2017.02.22-r1/work/deqp-2017.02.22_build
deqp-2017.02.22-r1:  * ERROR: media-gfx/deqp-2017.02.22-r1::chromiumos failed (configure phase):

Comment 2 by ihf@chromium.org, Feb 23 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3d8e6fd4828764cd96938434729deb543c4fdcfb

commit 3d8e6fd4828764cd96938434729deb543c4fdcfb
Author: Zach Reizner <zachr@google.com>
Date: Fri Feb 24 21:32:54 2017

media-gfx/deqp: sync deqp to aosp

BUG= chromium:689336 
TEST=test_that -b $BOARD $DUT graphics_dEQP.gles2-master
     graphics_dEQP.gles3-master graphics_dEQP.gles31-master

Change-Id: I7e306698972c9ca157991b6b7e5ace2b318db715
Reviewed-on: https://chromium-review.googlesource.com/445965
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/files/0001-targets-surfaceless-Add-support-for-Chrome-OS-surfac.patch
[modify] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/Manifest
[modify] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/files/0003-Added-support-for-creating-pBuffer-target.patch
[modify] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/files/0004-cmake-Use-FindPNG-instead-of-find_path-find_library.patch
[rename] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/deqp-2017.02.22-r1.ebuild
[modify] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/files/0002-Delete-compiler-check.patch
[modify] https://crrev.com/3d8e6fd4828764cd96938434729deb543c4fdcfb/media-gfx/deqp/files/0005-platform-surfaceless-Add-Vulkan-support.patch

Comment 4 by ihf@chromium.org, Feb 27 2017

Unfortunately the uprev caused a regression
https://wmatrix.googleplex.com/platform/unfiltered?suites=bvt-cq&releases=tot&platforms=sentry&days_back=20

https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/103797778-chromeos-test/chromeos4-row8-rack9-host2/graphics_dEQP


02/27 12:42:53.466 INFO |     graphics_dEQP:0322| [1/6] TestCase: dEQP-VK.api.smoke.asm_triangle
02/27 12:42:53.466 DEBUG|     graphics_dEQP:0343| Running single: /usr/local/deqp/external/vulkancts/modules/vulkan/deqp-vk --deqp-case=dEQP-VK.api.smoke.asm_triangle --deqp-surface-type=pbuffer --deqp-gl-config-name=rgba8888d24s8ms0 --deqp-log-images=disable --deqp-watchdog=enable --deqp-surface-width=256 --deqp-surface-height=256 --deqp-log-filename=/tmp/dEQP-VK.api.smoke-logs/dEQP-VK.api.smoke.asm_triangle.log
02/27 12:42:53.466 DEBUG|        base_utils:0185| Running '/usr/local/deqp/external/vulkancts/modules/vulkan/deqp-vk --deqp-case=dEQP-VK.api.smoke.asm_triangle --deqp-surface-type=pbuffer --deqp-gl-config-name=rgba8888d24s8ms0 --deqp-log-images=disable --deqp-watchdog=enable --deqp-surface-width=256 --deqp-surface-height=256 --deqp-log-filename=/tmp/dEQP-VK.api.smoke-logs/dEQP-VK.api.smoke.asm_triangle.log'
02/27 12:42:53.986 INFO |     graphics_dEQP:0398| Result: ResourceError

02/27 12:42:53.987 INFO |     graphics_dEQP:0322| [2/6] TestCase: dEQP-VK.api.smoke.asm_triangle_no_opname
02/27 12:42:53.987 DEBUG|     graphics_dEQP:0343| Running single: /usr/local/deqp/external/vulkancts/modules/vulkan/deqp-vk --deqp-case=dEQP-VK.api.smoke.asm_triangle_no_opname --deqp-surface-type=pbuffer --deqp-gl-config-name=rgba8888d24s8ms0 --deqp-log-images=disable --deqp-watchdog=enable --deqp-surface-width=256 --deqp-surface-height=256 --deqp-log-filename=/tmp/dEQP-VK.api.smoke-logs/dEQP-VK.api.smoke.asm_triangle_no_opname.log
02/27 12:42:53.987 DEBUG|        base_utils:0185| Running '/usr/local/deqp/external/vulkancts/modules/vulkan/deqp-vk --deqp-case=dEQP-VK.api.smoke.asm_triangle_no_opname --deqp-surface-type=pbuffer --deqp-gl-config-name=rgba8888d24s8ms0 --deqp-log-images=disable --deqp-watchdog=enable --deqp-surface-width=256 --deqp-surface-height=256 --deqp-log-filename=/tmp/dEQP-VK.api.smoke-logs/dEQP-VK.api.smoke.asm_triangle_no_opname.log'
02/27 12:42:54.207 INFO |     graphics_dEQP:0398| Result: ResourceError

Comment 6 by za...@chromium.org, Mar 1 2017

It also went form 81464 to 132534 tests. Looks like the common 8 are around dEQP-VK.glsl.builtin.precision.*. I'm having problems figuring out which specific tests failed as the logs are sent to /tmp and the only thing the stdout has is a running count of failures ever 100 tests. It seems that the increase in failures is because of new tests, based on my random poking around the logs.

Comment 7 by ihf@chromium.org, Mar 1 2017

Status: Fixed (was: Started)
You are right. Ok, then that's it for now.
03/01 03:15:38.035 INFO |     graphics_dEQP:0484| {'NotSupported': 31536, 'QualityWarning': 4, 'Timeout': 1, 'Pass': 100873, 'Fail': 103, 'ResourceError': 17}

The test should have an easier way to spew the failures, maybe at the very end again.

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment