Investigate copy constructor of StyleVisualData |
|||
Issue descriptionIn https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/StyleVisualData.cpp?l=40 , the m_zoom member is not copied, but set to the initial zoom value. Hence, every time StyleVisualData is copied for copy-on-write, the zoom is reset. There's no comment to indicate that this was intended. This needs to be investigated to see if it was intentional.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24835036681c326052b092b9697333ad9f4c2a9b commit 24835036681c326052b092b9697333ad9f4c2a9b Author: shend <shend@chromium.org> Date: Thu Feb 09 23:11:23 2017 Copy StyleVisualData::m_zoom in copy constructor. Currently StyleVisualData::m_zoom is reset to the initial zoom value every time StyleVisualData is copied using the copy constructor. There is no indication that this is intentional. This patch changes the code to actually copy m_zoom instead of resetting it. We tried to obtain a repro test case by running trybots with a DCHECK to see if the bug is reacheable, but the trybots passed. We also tried to find the commit that introduced this, but the code is very old and we couldn't trace its origin. It is most likely a copy and paste error, and even if it is not, this code is not dependable due to copy elision. See https://codereview.chromium.org/2687533004 for more details. BUG= 689330 Review-Url: https://codereview.chromium.org/2686013002 Cr-Commit-Position: refs/heads/master@{#449451} [modify] https://crrev.com/24835036681c326052b092b9697333ad9f4c2a9b/third_party/WebKit/Source/core/style/StyleVisualData.cpp
,
Feb 12 2017
,
Feb 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Feb 9 2017