New issue
Advanced search Search tips

Issue 689329 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: jailbreak would cause cras to fail.

Project Member Reported by hungte@chromium.org, Feb 7 2017

Issue description

What steps will reproduce the problem?
(1) Run ToT factory toolkit
(2) Try to open a new window to playback youtube

What is the expected result?
Hear audio

What happens instead?
Nothing from audio.


This is related to our jailbreak function that we didn't implement '-G' (inherit suppl groups). Adding a os.initgroups should solve it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/87c0f5d9e54f6854954cdef2c3fd547049a06cc3

commit 87c0f5d9e54f6854954cdef2c3fd547049a06cc3
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Feb 08 04:22:33 2017

init: jailbreak: Fix audio (cras) and bluetoothd.

cras.conf and bluetoothd.conf uses '-G' when calling minijail0, which
will inherit supplementary groups from UID, since they need access to
files owned by different groups (for instance, 'audio', 'input').
We need to call os.initgroups to get all group permissions.

BUG= chromium:689329 
TEST=make toolkit
     Manually invoked on DUT, opened Youtube and hear audio playback.

Change-Id: Ia35208b16817f5dd41b1c8005445c3d0abd7cfdd
Reviewed-on: https://chromium-review.googlesource.com/438944
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/87c0f5d9e54f6854954cdef2c3fd547049a06cc3/init/goofy.d/device/jailbreak/minijail0

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 8 2017

Labels: merge-merged-factory-gru-9017.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/7622a5473f5d98e942f621ca76d8a455549a6397

commit 7622a5473f5d98e942f621ca76d8a455549a6397
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Feb 08 06:17:01 2017

init: jailbreak: Fix audio (cras) and bluetoothd.

cras.conf and bluetoothd.conf uses '-G' when calling minijail0, which
will inherit supplementary groups from UID, since they need access to
files owned by different groups (for instance, 'audio', 'input').
We need to call os.initgroups to get all group permissions.

BUG= chromium:689329 
TEST=make toolkit
     Manually invoked on DUT, opened Youtube and hear audio playback.

Change-Id: Ia35208b16817f5dd41b1c8005445c3d0abd7cfdd
Reviewed-on: https://chromium-review.googlesource.com/438944
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit 87c0f5d9e54f6854954cdef2c3fd547049a06cc3)
Reviewed-on: https://chromium-review.googlesource.com/439028

[modify] https://crrev.com/7622a5473f5d98e942f621ca76d8a455549a6397/init/goofy.d/device/jailbreak/minijail0

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2017

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a6bc79232008afb3be698175f3ef4c0a0c799525

commit a6bc79232008afb3be698175f3ef4c0a0c799525
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Apr 27 09:13:56 2017

init: jailbreak: Fix audio (cras) and bluetoothd.

cras.conf and bluetoothd.conf uses '-G' when calling minijail0, which
will inherit supplementary groups from UID, since they need access to
files owned by different groups (for instance, 'audio', 'input').
We need to call os.initgroups to get all group permissions.

BUG= chromium:689329 
TEST=make toolkit
     Manually invoked on DUT, opened Youtube and hear audio playback.

Change-Id: Ia35208b16817f5dd41b1c8005445c3d0abd7cfdd
Reviewed-on: https://chromium-review.googlesource.com/438944
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit 87c0f5d9e54f6854954cdef2c3fd547049a06cc3)
Reviewed-on: https://chromium-review.googlesource.com/487852
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/a6bc79232008afb3be698175f3ef4c0a0c799525/init/goofy.d/device/jailbreak/minijail0

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment