New issue
Advanced search Search tips

Issue 689293 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

Return no VR devices in Chrome Custom Tabs

Project Member Reported by sko...@chromium.org, Feb 7 2017

Issue description

Per  Issue 688611 , WebVR doesn't work in Chrome Custom Tabs presently.  Rather than having the user try it only to have it open Chrome, we should affirmatively disable support for WebVR presentation in CCT (see Comment #1 in linked bug).
 
Issue 689775 has been merged into this issue.
Cc: vsupruniuk@google.com
Labels: -VR-DF M-58
vsupruniuk, please test via the steps in issue 689775 once this is fixed.
Labels: -Restrict-View-Google
Labels: -Proj-VR-Shell Proj-VR
Note that without this change CCT can crash as in issue 689775.
Owner: mthiesse@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/182cf17def973f5d7a981025afb65ebd6f022ca9

commit 182cf17def973f5d7a981025afb65ebd6f022ca9
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Mar 03 02:31:26 2017

Implement lazy initialization for VrShellDelegate

This allows VrShellDelegate to be created when it's needed, removing memory overhead for VR support when VR is not used.

This CL also allows for VrShellDelegate to be destroyed once it's no longer needed as well, but that will be implemented in a follow up CL.

Also also, this paves the way for allowing VrShellDelegate to attach to arbitrary ChromeActivities in the future (though for now only CTA is supported)

Also also also, this fixes VrShellDelegate being accessible from CCT (and webview?) so that they now correctly return no displays available.

BUG= 655297 ,  689293 

Review-Url: https://codereview.chromium.org/2727873002
Cr-Commit-Position: refs/heads/master@{#454474}

[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/device/vr/android/gvr/gvr_delegate.cc
[modify] https://crrev.com/182cf17def973f5d7a981025afb65ebd6f022ca9/device/vr/android/gvr/gvr_delegate.h

Labels: Merge-Request-58
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 3 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 3 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d

commit 7cc487a97758ef4bdb217f80bf3eee82c13c9f6d
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Mar 03 18:13:28 2017

Implement lazy initialization for VrShellDelegate

This allows VrShellDelegate to be created when it's needed, removing memory overhead for VR support when VR is not used.

This CL also allows for VrShellDelegate to be destroyed once it's no longer needed as well, but that will be implemented in a follow up CL.

Also also, this paves the way for allowing VrShellDelegate to attach to arbitrary ChromeActivities in the future (though for now only CTA is supported)

Also also also, this fixes VrShellDelegate being accessible from CCT (and webview?) so that they now correctly return no displays available.

BUG= 655297 ,  689293 

Review-Url: https://codereview.chromium.org/2727873002
Cr-Commit-Position: refs/heads/master@{#454474}
(cherry picked from commit 182cf17def973f5d7a981025afb65ebd6f022ca9)

Review-Url: https://codereview.chromium.org/2730903007 .
Cr-Commit-Position: refs/branch-heads/3029@{#3}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/device/vr/android/gvr/gvr_delegate.cc
[modify] https://crrev.com/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d/device/vr/android/gvr/gvr_delegate.h

Status: Fixed (was: Assigned)
Confirmed that the fix works in Gmail - page says that WebVR is supported, but no VR Displays found.
Components: Blink>WebXR

Sign in to add a comment