piex_loader.js is noisy in chromium browser_tests |
|||||
Issue descriptionIn chromium, the Promise created in the PiexLoader constructor (piex_loader.js) is rejected with "PiexLoader is not enabled for chromium build." The Promise is not caught, so it always outputs this as a console error. It shows up in browser_tests logs as: [25655:25655:0206/123627.428061:INFO:CONSOLE(0)] "Uncaught (in promise) PiexLoader is not enabled for chromium build.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/_generated_background_page.html (0) Is this warning important or can it be removed? Is it a bug when tests encounter this warning (should calls to PiexLoader be predicated on whether it's available in the build?)? https://cs.chromium.org/chromium/src/ui/file_manager/image_loader/piex_loader.js?type=cs&q=%22PiexLoader+is+not+enabled+for+chromium+build.%22
,
Feb 7 2017
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6423d6b3eea01831f79139b2d9408dc565a45077 commit 6423d6b3eea01831f79139b2d9408dc565a45077 Author: hirono <hirono@chromium.org> Date: Thu Feb 09 05:04:28 2017 Remove rejected promise of PiexLoader which is not caught. Previously if PiexLoader was not enabled for the build, PiexLoader.naclPromise_ was rejected and the rejected promise automatically appeared in console.log. The CL fulfills a boolean value to naclPromise_ instead of fullfills/rejects it to reducy noisy uncaught promise logs. Bug= 689264 Test=Manually run Files app with disabling Piex and checked the console. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2675193005 Cr-Commit-Position: refs/heads/master@{#449204} [modify] https://crrev.com/6423d6b3eea01831f79139b2d9408dc565a45077/ui/file_manager/image_loader/piex_loader.js [modify] https://crrev.com/6423d6b3eea01831f79139b2d9408dc565a45077/ui/file_manager/image_loader/request.js
,
Feb 9 2017
,
Apr 17 2017
,
May 8 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hirono@chromium.org
, Feb 6 2017