New issue
Advanced search Search tips

Issue 689232 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Errors that prevent the payment request from being shown should be recorded separately

Project Member Reported by se...@chromium.org, Feb 6 2017

Issue description

They should not be logged as aborts, since the user never saw the payment request.
 

Comment 2 by se...@chromium.org, Feb 9 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8754e89ee5a417f3fc2406beee9b002a20bd393c

commit 8754e89ee5a417f3fc2406beee9b002a20bd393c
Author: sebsg <sebsg@chromium.org>
Date: Tue Feb 14 15:44:15 2017

[Merge-57] Only record abort metrics if the Payment Request was shown.

Also move the metrics of event that prevent showing the payment request to their separate bucket.

BUG= 689111 , 689232 

Review-Url: https://codereview.chromium.org/2678903002
Cr-Commit-Position: refs/heads/master@{#449325}
(cherry picked from commit 752b06a473dd6f9a4072c9412431a90aa70f6f81)

Review-Url: https://codereview.chromium.org/2692853005 .
Cr-Commit-Position: refs/branch-heads/2987@{#498}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/8754e89ee5a417f3fc2406beee9b002a20bd393c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8754e89ee5a417f3fc2406beee9b002a20bd393c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/8754e89ee5a417f3fc2406beee9b002a20bd393c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/8754e89ee5a417f3fc2406beee9b002a20bd393c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/8754e89ee5a417f3fc2406beee9b002a20bd393c/tools/metrics/histograms/histograms.xml

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment