New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Extension install prompt strings need to be title-cased for mac

Project Member Reported by rdevlin....@chromium.org, Feb 6 2017

Issue description

Mac uses title case for headings and button strings.  The extension install prompt needs to be updated.

This was originally raised in issue 669277, but applies to much more than just that.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/708150fa6719a691befd72702ac6d5221db6d853

commit 708150fa6719a691befd72702ac6d5221db6d853
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon Feb 06 23:57:36 2017

[Extensions UI Mac] Update external install prompt strings to titlecase

Mac uses title case for buttons. Update the external install prompt
strings to use title case.

BUG=669277
BUG= 689227 

Review-Url: https://codereview.chromium.org/2680613002
Cr-Commit-Position: refs/heads/master@{#448448}

[modify] https://crrev.com/708150fa6719a691befd72702ac6d5221db6d853/chrome/app/generated_resources.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f8d139f448266d41723a8fba0347a246111c03

commit c7f8d139f448266d41723a8fba0347a246111c03
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Feb 22 14:29:02 2017

[Extensions] Deprecate old install prompt types

Remove old install prompt types from the code. Because the enum is used
in histograms, this isn't removed completely, but we can comment them
out to make sure they aren't used.

Also move away from using the "array of messages" approach, because this
required padding with 0's for deprecated types, and was significantly
harder to read.

Finally, remove a few deprecated messages that were found by doing this.

BUG= 689227 

Review-Url: https://codereview.chromium.org/2705733002
Cr-Commit-Position: refs/heads/master@{#452038}

[modify] https://crrev.com/c7f8d139f448266d41723a8fba0347a246111c03/chrome/app/generated_resources.grd
[modify] https://crrev.com/c7f8d139f448266d41723a8fba0347a246111c03/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/c7f8d139f448266d41723a8fba0347a246111c03/chrome/browser/extensions/extension_install_prompt.h

Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Status: Fixed (was: Archived)
This was actually fixed with #1, and just never closed out.  Updating status.

Sign in to add a comment