New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689224 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

debugd: build_packages error on x86 boards not caught by Pre-CQs

Project Member Reported by nxia@chromium.org, Feb 6 2017

Issue description

https://chromium-review.googlesource.com/c/420974/

The pre-cqs did build the debugd package and pass without errors. But CQ failed to build debugd. Needs to figure out why pre-cq didn't catch the error.
 

Comment 1 by nxia@chromium.org, Feb 6 2017

Components: Infra>Client>ChromeOS
Labels: OS-Chrome
Noted on the email thread, but perhaps better to copy here for posterity: 
This issue did raise the question of "are different build machines (dev machine chroot, pre-cq, cq) running builds with different compiler flags?" 
If yes, why / can we help ensure that the flags are same everywhere?
The issue happened due to -Werrror on the CQ, and I think the developer was able to build successfully on their machine, so they didn't catch it.  

Comment 3 by nxia@chromium.org, Feb 6 2017

Re #2:

kirtika@, in this special case https://chromium-review.googlesource.com/c/420974/, what's the flag causing the difference in compiling debugd package? 

Comment 4 by nxia@chromium.org, Feb 6 2017

Cc: akes...@chromium.org vapier@chromium.org

Comment 5 by nxia@chromium.org, Feb 6 2017

Is the arch type (ARM/x86) causing the difference in pre-cqs and cqs ?
Summary: debugd: build_packages error on x86 boards not caught by Pre-CQs (was: debugd: buildpackages error not caught by Pre-CQs)
yes, this comes down (again) to our pre-existing bug that we don't currently have any x86 bots listed in the pre-cq configs
What's a good candidate? I suppose we can catch this sort of thing with just build_packages and unit test? If so, this is cheap to add (plenty of gce buildslave capacity for this).
x86-alex-no-vmtest-pre-cq i think would be fine
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7b6bb79ed88eade5c75b4b66670c5419b1aafac4

commit 7b6bb79ed88eade5c75b4b66670c5419b1aafac4
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed Feb 08 04:14:26 2017

constants: add x86-alex-no-vmtest-pre-cq to default set

BUG= chromium:689224 
TEST=x86-alex-no-vmtest-pre-cq tryjob

Change-Id: I241c65a42cda10321b41a9dce45fb352f9ec8a2c
Reviewed-on: https://chromium-review.googlesource.com/438783
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7b6bb79ed88eade5c75b4b66670c5419b1aafac4/lib/constants.py

Comment 10 by nxia@chromium.org, Feb 8 2017

Cc: nxia@chromium.org dgarr...@chromium.org itspeter@chromium.org diand...@chromium.org derat@chromium.org sjg@chromium.org sbasi@chromium.org semenzato@chromium.org
 Issue 675657  has been merged into this issue.

Comment 11 by nxia@chromium.org, Feb 8 2017

Owner: akes...@chromium.org
Status: Fixed (was: Untriaged)

Comment 12 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 13 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 15 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment