New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 689219 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ holte@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UkmPageLoadMetricsObserver isn't fully reliable

Project Member Reported by rkaplow@chromium.org, Feb 6 2017 
I added a debug statement:
void UkmService::BuildAndStoreLog() {
  ...
  for (const auto& source : sources_) {
    Source* proto_source = report.add_sources();
    source->PopulateProto(proto_source);
    DVLOG(1) << "UkmService::SOURCE" << proto_source->url();
  }

I browse around to several websites. I often find that the URLs loaded are not displayed.
I find it is worse when several URLs are loaded in parallel, across different tabs.

This is on linux.

Comment 1 by oysteine@chromium.org, Feb 7 2017 

I currently have a check in the pageloadmetrics observer which ditches data for tabs that load (partially or fully) in the background, could that explain what you're seeing?

I figured until we have events for backgrounding status, it could keep the data less variable (and is based on the assumption that we'll get enough data regardless). That's not really based on anything more solid than a gut feeling though, so I don't mind removing the check if it'll get us a wider range of data.

Comment 2 by rkaplow@chromium.org, Feb 7 2017 

Ah yes, that's likely it. 

I'm not sure, it's an interesting question. Pages loaded in background will probably have very different characteristics (for ex. session restore will load many pages at once, making all of them slower).

I don't mind leaving it for now but we probably want to think more on this.

Comment 3 by oysteine@chromium.org, Feb 7 2017 

Yeah that was my feeling as well, particularly as there's more and more measures added to prioritize resources depending on tab visible state.

Comment 4 by oysteine@chromium.org, Apr 26 2018

Owner: ----
Status: Available (was: Untriaged)
Looks like the check is still there, but this should probably have another owner.
►

Sign in to add a comment