New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Very annoying "Clickable" spoken repeatedly in many web apps, including Gmail/Hangouts

Project Member Reported by chaok@google.com, Feb 6 2017

Issue description

Chrome Version: 58.0.3004.0 (Official Build) canary(64-bit)
OS: Win10
Screen reader: NVDA 2016.4 and JAWS 18

Hangouts and Gmail, I frequently hear “clickable, clickable,” clickable”. I don’t want to change the NVDA setting since I do want to be able to hear when certain things are clickable. 

What steps will reproduce the problem?
(1) Using above combo on Gmail.com
(2) Using NVDA browse mode to traverse email messages or chat messages
(3) Note: the utterances when focused on messages

What is the expected result?
Clickable to not be reported

What happens instead?
Clickables are reported 3x


 

Comment 1 by chaok@google.com, Feb 6 2017

“The clickable issue is still not fixed. Sometimes text that isn’t clickable shows up as clickable. Or it’s the reverse -- in the Gride app, clickable text for requesting a ride doesn’t click with chrome. 

Comment 2 by hwi@chromium.org, Feb 6 2017

Cc: -hwi@chromium.org -pkasting@chromium.org -rpop@chromium.org
Labels: -a11y-2017
removing label and cc after chat w/ chaok@
Labels: NewComponent-Accessibility NewComponent-Accessibility-Compatibility
Components: UI>Accessibility>Compatibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 27 2017

Labels: Hotlist-Google
Labels: triage-aaron
Labels: -Pri-2 -triage-aaron Pri-1
Status: Available (was: Untriaged)
P1. This drives people crazy.
Summary: Very annoying "Clickable" spoken repeatedly in many web apps, including Gmail/Hangouts (was: Clickable verbalizations in Gmail/Hangouts)
Cc: nek...@chromium.org
Here is the corresponding Mozilla bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1395181
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdebd9e7938a69714ca2f0e948e3e1729846e4ba

commit bdebd9e7938a69714ca2f0e948e3e1729846e4ba
Author: Nektarios Paisios <nektar@chromium.org>
Date: Wed Sep 06 02:20:10 2017

Reduces the number of items that are announced as clickable by Jaws or NVDA.

An element gets the click action when there is an anchor or an element with a click listener in its ancestry chain. For the latter case this change exposes a different action name, "click_ancestor", on Windows to stop Windows screen readers unnecessarily announcing many items as clickable.
Bug:  689201 
R=dmazzoni@chromium.org, aleventhal@chromium.org
TESTED=Manually with NVDA, browser test, layout test

Change-Id: I19ed8c53861b47e7f5fbe884c474a1c07afee916
Reviewed-on: https://chromium-review.googlesource.com/602261
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499854}
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/test/data/accessibility/html/a-onclick-expected-blink.txt
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/test/data/accessibility/html/a-onclick-expected-win.txt
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/test/data/accessibility/html/a-onclick.html
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/test/data/accessibility/html/action-verbs-expected-blink.txt
[add] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/test/data/accessibility/html/action-verbs-expected-win.txt
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/content/test/data/accessibility/html/action-verbs.html
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/LayoutTests/accessibility/clickable-expected.txt
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/LayoutTests/accessibility/clickable.html
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/Source/modules/accessibility/AXEnums.cpp
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/Source/modules/accessibility/AXEnums.h
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/ui/accessibility/ax_text_utils.cc
[modify] https://crrev.com/bdebd9e7938a69714ca2f0e948e3e1729846e4ba/ui/strings/ui_strings.grd

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8739dff9cd72a0a8d4325fc6d26393df882bb0

commit 2c8739dff9cd72a0a8d4325fc6d26393df882bb0
Author: Nektarios Paisios <nektar@chromium.org>
Date: Mon Oct 09 17:41:57 2017

Stops ignoring clickable elements.

With the addition of |AXActionVerb::ClickAncestor| there were some situations when the click handler was on an element that was ignored. When the AT tried to go up the ancestry chain to find the clickable element, it failed.
R=aleventhal@chromium.org
TESTED=Layout test

Bug:  689201 
Change-Id: I2833e19eca34e8e95529f5eef58c21a379e99c56
Reviewed-on: https://chromium-review.googlesource.com/699975
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507401}
[modify] https://crrev.com/2c8739dff9cd72a0a8d4325fc6d26393df882bb0/content/test/data/accessibility/html/menu-type-context-expected-blink.txt
[modify] https://crrev.com/2c8739dff9cd72a0a8d4325fc6d26393df882bb0/content/test/data/accessibility/html/menu-type-context-expected-mac.txt
[modify] https://crrev.com/2c8739dff9cd72a0a8d4325fc6d26393df882bb0/content/test/data/accessibility/html/menu-type-context-expected-win.txt
[modify] https://crrev.com/2c8739dff9cd72a0a8d4325fc6d26393df882bb0/third_party/WebKit/LayoutTests/accessibility/clickable-expected.txt
[modify] https://crrev.com/2c8739dff9cd72a0a8d4325fc6d26393df882bb0/third_party/WebKit/LayoutTests/accessibility/clickable.html
[modify] https://crrev.com/2c8739dff9cd72a0a8d4325fc6d26393df882bb0/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Owner: nek...@chromium.org
Status: Fixed (was: Available)
We did whatever we could from our side. We only expose the clickable action on items that have a click handler directly placed on them. We made a change excluding any click handlers that are found on ancestors.
Labels: win-a11y

Sign in to add a comment