Crashes in views_mus_interactive_ui_tests |
||
Issue descriptionIn views_mus_interactive_ui_tests, we have a few tests which pass, but also crash. Here are a few stacks: [21391:21391:0206/134442.035605:2951024760085:FATAL:window_manager_constants.mojom-shared.h(525)] The outgoing message will trigger VALIDATION_ERROR_UNEXPECTED_NULL_POINTER at the receiving side (null frame_decoration_values in WsDisplay struct). #0 0x7efe88185c3b base::debug::StackTrace::StackTrace() #1 0x7efe881842bc base::debug::StackTrace::StackTrace() #2 0x7efe881e79ac logging::LogMessage::~LogMessage() #3 0x0000004a8a37 mojo::internal::Serializer<>::Serialize() #4 0x0000004a86f2 _ZN4mojo8internal9SerializeIN2ui5mojom17WsDisplayDataViewERNS_9StructPtrINS3_9WsDisplayEEEJRPNS0_6BufferERPPNS3_8internal14WsDisplay_DataERPNS0_20SerializationContextEELPv0EEEvOT0_DpOT1_ #5 0x0000004a8689 mojo::internal::ArraySerializer<>::SerializeCaller<>::Run<>() #6 0x0000004a84ac mojo::internal::ArraySerializer<>::SerializeElements() #7 0x0000004a8406 mojo::internal::Serializer<>::Serialize() #8 0x0000004a740a _ZN4mojo8internal9SerializeINS_13ArrayDataViewIN2ui5mojom17WsDisplayDataViewEEERNSt7__debug6vectorINS_9StructPtrINS4_9WsDisplayEEESaISB_EEEJPNS0_6BufferEPPNS0_10Array_DataINS0_7PointerINS4_8internal14WsDisplay_DataEEEEEPKNS0_23ContainerValidateParamsEPNS0_20SerializationContextEELPv0EEEvOT0_DpOT1_ #9 0x0000004a5146 ui::mojom::DisplayManagerObserverProxy::OnDisplays() #10 0x0000006ee0f9 ui::ws::UserDisplayManager::CallOnDisplays() #11 0x0000006ee094 ui::ws::UserDisplayManager::OnObserverAdded() #12 0x0000006ee05a ui::ws::UserDisplayManager::AddObserver() #13 0x0000004a6eb4 ui::mojom::DisplayManagerStubDispatch::Accept() #14 0x0000006f3423 ui::mojom::DisplayManagerStub<>::Accept() #15 0x7efe8896147e mojo::InterfaceEndpointClient::HandleValidatedMessage() #16 0x7efe88960e91 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() And also: Received signal 11 SEGV_MAPERR 000000000000 #0 0x7fafe65fdc3b base::debug::StackTrace::StackTrace() #1 0x7fafe65fc2bc base::debug::StackTrace::StackTrace() #2 0x7fafe65fd74f base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7fafe6a30330 <unknown> #4 0x7fafe6170643 aura::CaptureSynchronizer::SetCaptureFromServer() #5 0x7fafe61b1d21 aura::WindowTreeClient::OnCaptureChanged() #6 0x7fafe62619b1 ui::mojom::WindowTreeClientStubDispatch::Accept() #7 0x7fafe61c1b93 ui::mojom::WindowTreeClientStub<>::Accept() #8 0x7fafe608847e mojo::InterfaceEndpointClient::HandleValidatedMessage() #9 0x7fafe6087e91 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() #10 0x7fafe6085ce0 mojo::FilterChain::Accept() #11 0x7fafe6089b0f mojo::InterfaceEndpointClient::HandleIncomingMessage()
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0802870f9ed84e195d8788d5aca277d59dbc33e8 commit 0802870f9ed84e195d8788d5aca277d59dbc33e8 Author: erg <erg@chromium.org> Date: Tue Feb 07 01:06:50 2017 aura mus: Install a DefautlCaptureClient in the TestWM. The TestWM crashes when trying to synchronize capture changes from the client because it doesn't have a CaptureClient. After TestWM has crashed, it stays crashed while running the views_mus_interactive_ui_tests suite, which leads to secondary hangs and retries due to flakiness. This decreases a run of that test suite from over 400 seconds to 10 seconds. BUG= 689197 Review-Url: https://codereview.chromium.org/2677023007 Cr-Commit-Position: refs/heads/master@{#448483} [modify] https://crrev.com/0802870f9ed84e195d8788d5aca277d59dbc33e8/services/ui/test_wm/test_wm.cc
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6de7e04fc91c39ee5c85b4fa098ba2f8d26a9d7 commit a6de7e04fc91c39ee5c85b4fa098ba2f8d26a9d7 Author: erg <erg@chromium.org> Date: Tue Feb 07 22:24:43 2017 Fix shutdown crashes by ensuring a valid MessageLoop. The WindowServer crashes during shutdown when there are open handles because ThreadTaskRunnerHandle will crash when there isn't a valid MessageLoop. Don't manually destroy the MessageLoop. BUG= 689197 Review-Url: https://codereview.chromium.org/2683543003 Cr-Commit-Position: refs/heads/master@{#448742} [modify] https://crrev.com/a6de7e04fc91c39ee5c85b4fa098ba2f8d26a9d7/services/service_manager/public/cpp/lib/service_runner.cc
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78c9144a00abf91237afd62d3fadea59f78298e9 commit 78c9144a00abf91237afd62d3fadea59f78298e9 Author: erg <erg@chromium.org> Date: Wed Feb 08 01:18:55 2017 aura-mus: Destroy the capture client before the tree client in TestWM. Now that we don't crash on the beginning of shutdown, we get to the point where we crash in yesterday's changes to TestWM. Ensure that the DefaultCaptureClient added yesterday is destroyed before we try to destroy the WindowTreeHost. views_mus_interactive_ui_tests is now crash-free locally. BUG= 689197 Review-Url: https://codereview.chromium.org/2682793003 Cr-Commit-Position: refs/heads/master@{#448830} [modify] https://crrev.com/78c9144a00abf91237afd62d3fadea59f78298e9/services/ui/test_wm/test_wm.cc
,
Feb 8 2017
the crashes in the test suite are fixed. there are still flaky retry hangs though and let's track that in kylechar's issue 690156 . |
||
►
Sign in to add a comment |
||
Comment 1 by e...@chromium.org
, Feb 6 2017