New issue
Advanced search Search tips

Issue 689173 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Banner does not show for https://pwassemble.herokuapp.com/?id=5914969367379968 when --bypass-app-banner-engagement-checks is passed

Project Member Reported by pkotw...@chromium.org, Feb 6 2017

Issue description

Banner does not show for https://pwassemble.herokuapp.com/?id=5914969367379968 when --bypass-app-banner-engagement-checks is passed

I think that this is because https://pwassemble.herokuapp.com/?id=5914969367379968 sets the manifest via Javascript and InstallableManager does not detect the web page adding the <link rel="manifest"> tag
 
Cc: dominickn@chromium.org pkotw...@chromium.org hanxi@chromium.org
Labels: -OS-Android
Removing Android OS. This bug affects all platforms
The banner checking is triggered when AppBannerManager::DidFinishLoad is called. If the site injects its manifest after the load event is dispatched, then there's not really anything we can do. It's not feasible to poll and wait until a manifest link appears.

If it really wants to inject a manifest tag via Javascript, it should do in a script section in the head or something like that so it happens before the banner pipeline starts.
One option would be to plumb ManifestManager::DidChangeManifest() on the renderer side to Chrome. We do something similar for the page title and for favicons. I am unsure whether it is worth it for the manifest URL.
Status: WontFix (was: Untriaged)
I'm not particularly enamoured of adding more IPC to account for this since all of the usual advice is to use static link tags for the manifest. WontFixing for now; we can reconsider this in future if a huge trend towards late injection of manifests occurs.

Sign in to add a comment