New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PlzNavigate: layout tests involving 204 response timeout

Project Member Reported by yzshen@chromium.org, Feb 6 2017

Issue description

http/tests/navigation/response204.html
virtual/stable/http/tests/navigation/response204.html
virtual/mojo-loading/http/tests/navigation/response204.html
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e60da02d2e136fa7cc20abf8858b00846cbd331

commit 0e60da02d2e136fa7cc20abf8858b00846cbd331
Author: clamy <clamy@chromium.org>
Date: Fri Feb 17 12:41:16 2017

Remove one navigation layout test

This CL removes http/tests/navigation/response204.html. This test checks
that a 204 response on a browser-initiated navigation will not result in
an extra item in the navigation history. This is better tested as
content_browsertest, especially since it cannot be tested using a layout
test when PlzNavigate is enabled (renderers are not made aware of a
browser-initiated navigation resulting in a 204).

BUG= 689153 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2695093006
Cr-Commit-Position: refs/heads/master@{#451288}

[modify] https://crrev.com/0e60da02d2e136fa7cc20abf8858b00846cbd331/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[add] https://crrev.com/0e60da02d2e136fa7cc20abf8858b00846cbd331/content/test/data/page204.html
[add] https://crrev.com/0e60da02d2e136fa7cc20abf8858b00846cbd331/content/test/data/page204.html.mock-http-headers
[modify] https://crrev.com/0e60da02d2e136fa7cc20abf8858b00846cbd331/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
[delete] https://crrev.com/a7a2ee3f307090e4f5dd8848ce498c939993b3db/third_party/WebKit/LayoutTests/http/tests/navigation/response204-expected.txt
[delete] https://crrev.com/a7a2ee3f307090e4f5dd8848ce498c939993b3db/third_party/WebKit/LayoutTests/http/tests/navigation/response204.html

Comment 2 by clamy@chromium.org, Feb 17 2017

Status: Fixed (was: Untriaged)

Comment 3 by yzshen@chromium.org, Feb 17 2017

Hi, Camille.

The renderer side keeps state |browser_side_navigation_pending_|. Currently if a navigation results in 204 response, the renderer doesn't get notified and therefore won't update this field.

Does it make sense to notify the renderer in the case of 204 response?


Sign in to add a comment