Currently, SB HitReport is only gated by SB extended reporting preference, we should check whether user is in incognito mode and discard this report if it's true. https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/ui_manager.cc?l=155&ct=xref_jump_to_def&gsn=MaybeReportSafeBrowsingHit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdcd0b7cbe1630435abab4a03ca0543752138b56 commit cdcd0b7cbe1630435abab4a03ca0543752138b56 Author: mortonm <mortonm@google.com> Date: Fri May 19 22:20:00 2017 Even if user has SafeBrowsing Extended Reporting enabled, we want to refrain from sending a hit report when the user is in incognito mode. BUG= 689149 Review-Url: https://codereview.chromium.org/2886043002 Cr-Commit-Position: refs/heads/master@{#473360} [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/chrome/browser/safe_browsing/download_protection_service.cc [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/components/safe_browsing/base_ui_manager.cc [modify] https://crrev.com/cdcd0b7cbe1630435abab4a03ca0543752138b56/components/safe_browsing/base_ui_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e97150a20f315b0d7120da514a126fb5f2ccb41 commit 0e97150a20f315b0d7120da514a126fb5f2ccb41 Author: mortonm <mortonm@google.com> Date: Mon May 22 18:10:00 2017 Addressing comments on the CL that previously landed regarding not sending hit reports when the user is in incognito mode. This is a follow up of https://codereview.chromium.org/2886043002. BUG= 689149 Review-Url: https://codereview.chromium.org/2896893002 Cr-Commit-Position: refs/heads/master@{#473623} [modify] https://crrev.com/0e97150a20f315b0d7120da514a126fb5f2ccb41/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/0e97150a20f315b0d7120da514a126fb5f2ccb41/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [modify] https://crrev.com/0e97150a20f315b0d7120da514a126fb5f2ccb41/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/0e97150a20f315b0d7120da514a126fb5f2ccb41/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/0e97150a20f315b0d7120da514a126fb5f2ccb41/components/safe_browsing/base_ui_manager.cc [modify] https://crrev.com/0e97150a20f315b0d7120da514a126fb5f2ccb41/components/safe_browsing/base_ui_manager.h
Comment 1 by jialiul@chromium.org
, Apr 21 2017Owner: jialiul@chromium.org
Status: Assigned (was: Available)