New issue
Advanced search Search tips

Issue 689132 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: Hover over redirected request's initiator does not show anything

Project Member Reported by einbinder@chromium.org, Feb 6 2017

Issue description

If you go to a site like theverge.com with cache disabled that has a redirected request and open devtools, then hover over the initiator column it throws an error and doesn't show anything.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6004f9b3a66dce2ad170a521529d3414e26fb538

commit 6004f9b3a66dce2ad170a521529d3414e26fb538
Author: einbinder <einbinder@chromium.org>
Date: Mon Feb 06 21:30:44 2017

DevTools: Missing parenthesis on url in NetworkLog

BUG= 689132 

Review-Url: https://codereview.chromium.org/2667513002
Cr-Commit-Position: refs/heads/master@{#448396}

[modify] https://crrev.com/6004f9b3a66dce2ad170a521529d3414e26fb538/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

Cc: pbomm...@chromium.org
Labels: OS-Linux OS-Mac OS-Windows
einbinder@  can you please request for M57 merge, So that it get picked in next M57 release.

I am tagging all Desktop platforms.
Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 7 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cab60e67973d3ebde4ca325fa40a711dd7d3cc6

commit 0cab60e67973d3ebde4ca325fa40a711dd7d3cc6
Author: einbinder <einbinder@chromium.org>
Date: Tue Feb 07 23:59:31 2017

DevTools: Missing parenthesis on url in NetworkLog

BUG= 689132 

Review-Url: https://codereview.chromium.org/2667513002
Cr-Commit-Position: refs/heads/master@{#448396}
(cherry picked from commit 6004f9b3a66dce2ad170a521529d3414e26fb538)
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2680743005
Cr-Commit-Position: refs/branch-heads/2987@{#372}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/0cab60e67973d3ebde4ca325fa40a711dd7d3cc6/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
einbinder@ in order to verify this issue could you please help us with the steps to reproduce the scenario  and the expected result, so that we reproduce the scenario from TE-End.

Thank You...
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

if you go theverge.com, and hover over the initiator for the file analytics.js with status code 200, it should show the tooltip.


analytics.png
42.6 KB View Download
Had an offline chat with einbinder@ and based on that this is a really small edge case. Depends on like the angle we move your mouse over the element and how long you leave it there.It's an obvious bug in the code but its hard to get it to manifest itself(Copied from Chat)

Note : For now we are moving ahead with today's M57 release.
Labels: -Needs-Feedback TE-Verified-M57 TE-Verified-57.0.2987.37
Verified this issue on windows 10, Ubuntu 14.04 and Mac OS 10.12.3 using chrome latest M57-57.0.2987.37 by following steps mentioned in the comment #8.
Observed the tool tip on the analytics.js initiator column. 
Hence adding TE-Verified label.
Attaching the screencast for reference.

Thank You...
Issue 689132.mp4
1.3 MB View Download
einbinder@ : As per the above comment # 10 its already verified, could you please mark the status to Fixed.
A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
Status: Fixed (was: Assigned)

Sign in to add a comment