New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689128 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
USB


Sign in to add a comment

Suppress WebUSB notification when landing page already open

Project Member Reported by reillyg@chromium.org, Feb 6 2017

Issue description

Chrome Version: 58.0.3000.4
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Connect WebUSB device.
(2) Click on notification to open the landing page.
(3) Reconnect WebUSB device.

What is the expected result?
Since the device's landing page is already open there's no benefit to displaying the notification again.

What happens instead?
Notification reappears.


 
Labels: -OS-iOS

Comment 2 by scheib@chromium.org, Apr 26 2017

Owner: cco3@chromium.org
Status: Started (was: Assigned)
Patch out for review: https://codereview.chromium.org/2824923002/
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca47e28ab2e0f43b8b44874b3905676a3d961ce

commit dca47e28ab2e0f43b8b44874b3905676a3d961ce
Author: cco3 <cco3@chromium.org>
Date: Fri May 19 19:23:01 2017

Suppress WebUSB notifications when appropriate

Currently, a WebUSB notification appears regardless of whether the
landing page is already open.  This change takes a more refined
approach to WebUSB notifications, as outlined below.

Managing the notification:
- If the active tab is the landing page, don't fire a notification.
- If the the landing page becomes featured in the active tab and a
  notification exists, remove it.

When clicking a notification:
- If a tab exists with the landing page, activate it.
- If a tab does not exist with the landing page, create a new tab and
  navigate to the landing page.

BUG= 689128 

Review-Url: https://codereview.chromium.org/2824923002
Cr-Commit-Position: refs/heads/master@{#473273}

[modify] https://crrev.com/dca47e28ab2e0f43b8b44874b3905676a3d961ce/chrome/browser/chromeos/profiles/profile_helper.cc
[modify] https://crrev.com/dca47e28ab2e0f43b8b44874b3905676a3d961ce/chrome/browser/chromeos/profiles/profile_helper.h
[modify] https://crrev.com/dca47e28ab2e0f43b8b44874b3905676a3d961ce/chrome/browser/usb/web_usb_detector.cc
[modify] https://crrev.com/dca47e28ab2e0f43b8b44874b3905676a3d961ce/chrome/browser/usb/web_usb_detector_unittest.cc
[modify] https://crrev.com/dca47e28ab2e0f43b8b44874b3905676a3d961ce/tools/metrics/histograms/enums.xml

Comment 5 by cco3@chromium.org, May 19 2017

Status: Fixed (was: Started)

Sign in to add a comment