New issue
Advanced search Search tips

Issue 689118 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 689295
issue 689296

Blocking:
issue 657117
issue 693211



Sign in to add a comment

[WPT Export] Move exporter from being a workstation cron job to running on Chromium infra

Project Member Reported by jeffcarp@chromium.org, Feb 6 2017

Issue description

Steps:

- [x]  bug 689296  Request a new slave 
- [x] Add a new recipe for WPT Export https://chromium-review.googlesource.com/c/437763/
- [x]  bug 689295  Add the ability to pass GitHub creds as a JSON file to WPT Export
- [x] CL: Add the recipe + slave to chromium.infra.cron master
- [x] Create a GitHub bot using the w3c autoroller email
- [x] Get the bot merge access on WPT
- [x] SSH into the bot and add GitHub credentials
- [x] Fix cwd bugs https://codereview.chromium.org/2692233002
- [x] Fix remaining cwd bugs https://codereview.chromium.org/2690333005
- [x] Last step! Remove --dry-run https://chromium-review.googlesource.com/444149
 
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Blockedon: 689295
Blockedon: 689296
Description: Show this description
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7bc7d33360e55464c166a6a4fc70a87d26f2f978

commit 7bc7d33360e55464c166a6a4fc70a87d26f2f978
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Wed Feb 08 00:12:00 2017

Add WPT Export task to chromium.infra.cron

BUG= 689118 

Change-Id: I749bcead02e55a3b47bb6519d541186ad7af6872
Reviewed-on: https://chromium-review.googlesource.com/437763
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[add] https://crrev.com/7bc7d33360e55464c166a6a4fc70a87d26f2f978/recipes/recipes/wpt_export.py
[add] https://crrev.com/7bc7d33360e55464c166a6a4fc70a87d26f2f978/recipes/recipes/wpt_export.expected/wpt-export.json

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7bc7d33360e55464c166a6a4fc70a87d26f2f978

commit 7bc7d33360e55464c166a6a4fc70a87d26f2f978
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Wed Feb 08 00:12:00 2017

Add WPT Export task to chromium.infra.cron

BUG= 689118 

Change-Id: I749bcead02e55a3b47bb6519d541186ad7af6872
Reviewed-on: https://chromium-review.googlesource.com/437763
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[add] https://crrev.com/7bc7d33360e55464c166a6a4fc70a87d26f2f978/recipes/recipes/wpt_export.py
[add] https://crrev.com/7bc7d33360e55464c166a6a4fc70a87d26f2f978/recipes/recipes/wpt_export.expected/wpt-export.json

Description: Show this description
Description: Show this description
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/05f92884355b52c9088051571417e1956a4d340e

commit 05f92884355b52c9088051571417e1956a4d340e
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Mon Feb 13 12:58:47 2017

Add wpt-exporter to chromium.infra.cron

BUG= 689118 

Change-Id: I65631d8c35935a346a5cce24cd254c55f64ceb8a
Reviewed-on: https://chromium-review.googlesource.com/441106
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/05f92884355b52c9088051571417e1956a4d340e/masters/master.chromium.infra.cron/slaves.cfg
[modify] https://crrev.com/05f92884355b52c9088051571417e1956a4d340e/masters/master.chromium.infra.cron/master.cfg

Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcee4ae4d62ead9b398ee9f5afdf511fbb723962

commit bcee4ae4d62ead9b398ee9f5afdf511fbb723962
Author: jeffcarp <jeffcarp@chromium.org>
Date: Wed Feb 15 07:43:27 2017

[WPT Export] Fix omitted self in run_command argument

BUG= 689118 

Review-Url: https://codereview.chromium.org/2690343003
Cr-Commit-Position: refs/heads/master@{#450628}

[modify] https://crrev.com/bcee4ae4d62ead9b398ee9f5afdf511fbb723962/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py

Description: Show this description
Description: Show this description
Blocking: 693211
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/07c82abd4b65a01fe82bbb3bcbdad82761833eda

commit 07c82abd4b65a01fe82bbb3bcbdad82761833eda
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Mar 02 18:36:56 2017

Remove --dry-run from wpt-exporter, also change Git username

BUG= 689118 

Change-Id: I29c803bf1ec45f25a44b5f91be551349e1b8fe02
Reviewed-on: https://chromium-review.googlesource.com/444149
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/07c82abd4b65a01fe82bbb3bcbdad82761833eda/recipes/recipes/wpt_export.py
[modify] https://crrev.com/07c82abd4b65a01fe82bbb3bcbdad82761833eda/recipes/recipes/wpt_export.expected/wpt-export.json

Just removed --dry-run. Monitoring builds:
https://build.chromium.org/p/chromium.infra.cron/builders/wpt-exporter?numbuilds=200

I'll close this bug once it's been landed for a few hours and is stable.
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fc748c88ede0af87df36fe8c2b7d9e59bb28343

commit 3fc748c88ede0af87df36fe8c2b7d9e59bb28343
Author: Jeff Carpenter <jeffcarp@chromium.org>
Date: Thu Mar 02 19:56:15 2017

[WPT Export] Remove trailing whitespace to test exporter newly running on infra bot

BUG= 689118 
TBR=qyearsley@chromium.org

Change-Id: Id18e84e9c575615f80d7ab8c8cc21810d0c37ab0
Reviewed-on: https://chromium-review.googlesource.com/448248
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#454354}
[modify] https://crrev.com/3fc748c88ede0af87df36fe8c2b7d9e59bb28343/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-about-blank-allowed-by-default.sub.html

Status: Fixed (was: Assigned)
The infra bot had its first automated export!!!!
https://github.com/w3c/web-platform-tests/pull/5038
Description: Show this description
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment