Title correction: (or *dis*appears immediately)

Unable to reproduce the issue on Mac-10.12.2 using chrome stable version 56.0.2924.87 ,canary 58.0.3006.0 and Reported version 58.0.3004.0 with the steps mentioned above.

Please find the attached screencast and please let us know if anything missed here to reproduce the issue.

Thanks..

Deleted: 689115.mov 6.0 MB

689115.mov 6.0 MB Download

Hello sureshkumari@,

sorry, step (4) was not clear enough described. You have to put the cursor somewhere on the web content area and press CMD-T to open the new tabs.

This means now:

What steps will reproduce the problem?
(1) Open a Chrome window
(2) Go into Fullscreen Mode
(3) Select "Hide always Toolbar in Fullscreen Mode"
(4) Move the cursor somewhere on the page, so that the Toolbar area disappears
(5) Open some new Tabs with CMD-T

Adding milestone for RBS label. 

Able to reproduce the issue on Mac-10.12.2 using Chrome stable version 56.0.2924.87 and canary 58.0.3007.0 with the steps mentioned in comment#4.

This is Non-regression issue, Observed from M51 #51.0.2662.0 and confirming this issue to get more inputs from Dev team.

Please find the attached screencast for reference.

Note: From M30 to M50 there is no Option "Hide toolbar in full screen".

Thanks..

Deleted: Issue-689115.mov 5.2 MB

Issue-689115.mov 5.2 MB Download

It was definitely broken in Chrome 58.

Here is the regression range: https://chromium.googlesource.com/chromium/src/+log/891d0d69870da1d4470170dde087afe354e01e15..ef1da2f145faf9e26d457fdf39fe5c607506ccb1

spqchan@: Probably broken with https://codereview.chromium.org/2666213003

If you need more information, please let me know.

Thanks!

This is still reproducible on the latest canary(58.0.3018.0) of Mac OS 10.12.2.

spqchan@: Could you please take a look at this and update the thread.

This is still reproducible on the latest canary(58.0.3026.0) of Mac OS 10.12.3.

spqchan@: Could you please take a look at this and update the thread.

Gentle ping to get an update on this as it was marked as a blocker.
Thank you!!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e86cff1a78d3b1f75b454487afee3101d3504519

commit e86cff1a78d3b1f75b454487afee3101d3504519
Author: spqchan <spqchan@chromium.org>
Date: Fri Mar 10 18:51:33 2017

[Mac] Fullscreen Toolbar Fixes

- Fixed the layout issues with the fullscreen toolbar
- Fixed the hiding animation

BUG= 689115 

Review-Url: https://codereview.chromium.org/2738043002
Cr-Commit-Position: refs/heads/master@{#456117}

[modify] https://crrev.com/e86cff1a78d3b1f75b454487afee3101d3504519/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/e86cff1a78d3b1f75b454487afee3101d3504519/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/e86cff1a78d3b1f75b454487afee3101d3504519/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/e86cff1a78d3b1f75b454487afee3101d3504519/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm

Today I installed Chrome 57 Stable and I noticed this bug there too. 

So I checked https://codereview.chromium.org/2666213003, which caused this issue and I noticed that this CL was merged to M57 later with https://codereview.chromium.org/2671073002.

Therefore I am also adding M57 to this bug. Maybe it is possible to merge this fix after landing in M58 to land this in M57 too?

Thank you!

 Issue 699508  has been merged into this issue.

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

M58 Merge: Please merge you change to M58 branch 3029 before 5:00 PM PT, Monday on so we can take it in for next week dev release. Thank you.

M57 Merge:
Re #14, Please note M57 stable is already out for small percentage of users, plan to ramp up AU to 5% in on Monday.If this change is important to merge to M57 for future stable release (if any) and safe to merge, please request a merge to M57 once change is well baked/verified in Canary/M58 Dev. Thank you.

Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ef80f22ed957850a6d0149a507d9bc9cf5f07d

commit b5ef80f22ed957850a6d0149a507d9bc9cf5f07d
Author: spqchan <spqchan@chromium.org>
Date: Mon Mar 13 17:22:51 2017

[Mac] Fullscreen Toolbar Fixes

- Fixed the layout issues with the fullscreen toolbar
- Fixed the hiding animation

BUG= 689115 

Review-Url: https://codereview.chromium.org/2738043002
Cr-Commit-Position: refs/heads/master@{#456117}
(cherry picked from commit e86cff1a78d3b1f75b454487afee3101d3504519)

Review-Url: https://codereview.chromium.org/2748673003 .
Cr-Commit-Position: refs/branch-heads/3029@{#155}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/b5ef80f22ed957850a6d0149a507d9bc9cf5f07d/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/b5ef80f22ed957850a6d0149a507d9bc9cf5f07d/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/b5ef80f22ed957850a6d0149a507d9bc9cf5f07d/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/b5ef80f22ed957850a6d0149a507d9bc9cf5f07d/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm

Is it too late to merge into M57?

This bug requires manual review: Only 0 days from stable, we might already have a stable candidate build
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Talked to govind@ offline and since this bug isn't critical, we should avoid merging it to M57

Tested this issue on Mac 10.12.3 with chrome dev #58.0.3029.19

These are the steps followed
1. Launched chrome 
2. Disabled "Always show Toolbar in Full Screen"
3. Entered into fullscreen by typing "ctrl+cmd+F"
4. Opened few tabs using "Ctrl+T" cmd and observed that tab strip is appeared.
5. Moved the cursor somewhere and clicked on the page and observed that tab strip area 
   disappears

Attaching the screen-cast for reference.

spqchan@ could you confirm that this expected behavior of this fix.

Thank You...

Deleted: Issue 689115.mp4 1.1 MB

	Issue 689115.mp4 1.1 MB View Download

 Issue 701772  has been merged into this issue.

Yep, looks good thanks!

 Issue 693912  has been merged into this issue.

 Issue 703048  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/692ba2ee806a7680085c51c383e722744b7f1e61

commit 692ba2ee806a7680085c51c383e722744b7f1e61
Author: spqchan <spqchan@chromium.org>
Date: Wed Mar 22 17:38:15 2017

[Mac] Fullscreen Toolbar Fixes

- Fixed the layout issues with the fullscreen toolbar
- Fixed the hiding animation

BUG= 689115 

Review-Url: https://codereview.chromium.org/2738043002
Cr-Commit-Position: refs/heads/master@{#456117}
(cherry picked from commit e86cff1a78d3b1f75b454487afee3101d3504519)

Review-Url: https://codereview.chromium.org/2768843002 .
Cr-Commit-Position: refs/branch-heads/2987@{#860}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/692ba2ee806a7680085c51c383e722744b7f1e61/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/692ba2ee806a7680085c51c383e722744b7f1e61/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/692ba2ee806a7680085c51c383e722744b7f1e61/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/692ba2ee806a7680085c51c383e722744b7f1e61/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm

Rechecked the issue on Stable build 57.0.2987.123 on MAC 10.12.3 as per the steps provided in comment#23 and based on confirmation in comment#25, merge is working as intended. Adding TE-verified labels.