New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689100 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Linux ChromeOS Buildspec Tests failing for 57.0.2987.28

Project Member Reported by steve...@chromium.org, Feb 6 2017

Issue description

Oh, btw, test failure is: "KioskCrashRestoreTest.Basic"

Status: Started (was: Assigned)
yeah, the KioskCrashRestoreTest expectations have been broken by https://codereview.chromium.org/2669203006 (intentionally, the problem is that the test has been removed on ToT).

I wonder if we should merge fix for  issue 677340  (which removed the test in question).
Otherwise, I might resurrect the test on ToT, and merge the fix back to M57.
Or maybe just disable the test on the branch.

ketakid, wdyt?


57 builds are still failing (note the last build was for 56, this builter alternates):
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20ChromeOS%20Buildspec%20Tests

We need to decide what to do here.

Cc: jen...@chromium.org jhorwich@chromium.org
+ This week's gardeners

I like this option => I might resurrect the test on ToT, and merge the fix back to M57. That way we can make sure the test is ok first on master before it goes on branch.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac9147c505a91add2903a1aca8a72f6ec3398dae

commit ac9147c505a91add2903a1aca8a72f6ec3398dae
Author: tbarzic <tbarzic@chromium.org>
Date: Thu Feb 16 20:13:43 2017

Resurect KioskCrashRestore browser test

The test is still running on branches (and is currently broken, since
the expectations have changed since 57) - adding it back so the test
fix can be merged back.

BUG= 689100 

Review-Url: https://codereview.chromium.org/2695313002
Cr-Commit-Position: refs/heads/master@{#451075}

[add] https://crrev.com/ac9147c505a91add2903a1aca8a72f6ec3398dae/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/ac9147c505a91add2903a1aca8a72f6ec3398dae/chrome/test/BUILD.gn

Labels: M-57 Merge-Request-57
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 18 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34fdd24086b8d7c1e655afc5a31786414ea59cec

commit 34fdd24086b8d7c1e655afc5a31786414ea59cec
Author: Toni Barzic <tbarzic@google.com>
Date: Sat Feb 18 01:47:38 2017

Resurect KioskCrashRestore browser test

The test is still running on branches (and is currently broken, since
the expectations have changed since 57) - adding it back so the test
fix can be merged back.

BUG= 689100 

Review-Url: https://codereview.chromium.org/2695313002
Cr-Commit-Position: refs/heads/master@{#451075}
(cherry picked from commit ac9147c505a91add2903a1aca8a72f6ec3398dae)

Review-Url: https://codereview.chromium.org/2704813002 .
Cr-Commit-Position: refs/branch-heads/2987@{#588}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/34fdd24086b8d7c1e655afc5a31786414ea59cec/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc

Status: Fixed (was: Started)
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment