MD-Settings - Edit Page "Save" button is called "Edit" |
||||||||
Issue description1. Navigate to chrome://md-settings/onStartup 2. Choose "Open a specific page or set of pages" 3. Click "Add a new page" 4. Add any URL and click "Add" 5. Edit the previously added URL Expected: Button should say "Save" or "Ok" or "Update" instead of "Edit"
,
Feb 13 2017
,
Feb 13 2017
Tested on Mac os 10.12.2 , windows 7 and ubuntu 14.04 and issue is reproduced. Confirming the issue and marking it as untraiged , so that someone could address this. Thanks!
,
Feb 14 2017
,
Feb 22 2017
please mark bugs as started when you're actively working on them
,
Feb 22 2017
Sorry and thanks for changing that for me dbeam@. Screenshot post-fix attached.
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bf98d03dbef1c18a79d3d86cad0b526210deda2 commit 3bf98d03dbef1c18a79d3d86cad0b526210deda2 Author: scottchen <scottchen@chromium.org> Date: Thu Feb 23 00:26:19 2017 MD Settings: change confirm text to save startup url's dialog. BUG= 689093 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2707383002 Cr-Commit-Position: refs/heads/master@{#452304} [modify] https://crrev.com/3bf98d03dbef1c18a79d3d86cad0b526210deda2/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js
,
Feb 23 2017
,
Feb 28 2017
Verified on Mac os 10.12.2 , ubuntu 14.04 and windows 7 using chrome dev M58 #58.0.3025.5 and issue is not reproduced. MD-Settings - Edit Page "Save" button is called "save" and issue is fixed. Attached screencast for reference. Adding Te-Verified labels . Thanks!
,
Mar 6 2017
Verified on ChromeOS 9334.0.0 / 58.0.3028.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hcarmona@chromium.org
, Feb 6 2017