New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689093 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD-Settings - Edit Page "Save" button is called "Edit"

Project Member Reported by hcarmona@chromium.org, Feb 6 2017

Issue description

1. Navigate to chrome://md-settings/onStartup
2. Choose "Open a specific page or set of pages"
3. Click "Add a new page"
4. Add any URL and click "Add"
5. Edit the previously added URL

Expected:
Button should say "Save" or "Ok" or "Update" instead of "Edit"
 
%22Edit%22.png
42.7 KB View Download
Summary: MD-Settings - Edit Page "Save" button is called "Edit" (was: MD-Settings)

Comment 2 by ajha@chromium.org, Feb 13 2017

Components: UI>Settings
Labels: Needs-Milestone

Comment 3 by hdodda@chromium.org, Feb 13 2017

Cc: hdodda@chromium.org
Labels: -Needs-Milestone M-58
Status: Untriaged (was: Unconfirmed)
Tested on Mac os 10.12.2 , windows 7 and ubuntu 14.04 and issue is reproduced.

Confirming the issue and marking it as untraiged , so that someone could address this.

Thanks!

Comment 4 by dbeam@chromium.org, Feb 14 2017

Cc: dpa...@chromium.org
Labels: -Pri-3 Hotlist-MD-Settings-OnStartup OS-Chrome Pri-2
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by dbeam@chromium.org, Feb 22 2017

Status: Started (was: Assigned)
please mark bugs as started when you're actively working on them
Sorry and thanks for changing that for me dbeam@.
Screenshot post-fix attached.
save-dialog.png
17.9 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bf98d03dbef1c18a79d3d86cad0b526210deda2

commit 3bf98d03dbef1c18a79d3d86cad0b526210deda2
Author: scottchen <scottchen@chromium.org>
Date: Thu Feb 23 00:26:19 2017

MD Settings: change confirm text to save startup url's dialog.

BUG= 689093 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2707383002
Cr-Commit-Position: refs/heads/master@{#452304}

[modify] https://crrev.com/3bf98d03dbef1c18a79d3d86cad0b526210deda2/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js

Status: Fixed (was: Started)

Comment 9 by hdodda@chromium.org, Feb 28 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3025.5
Verified on Mac os 10.12.2 , ubuntu 14.04 and windows 7 using chrome dev M58 #58.0.3025.5 and issue is not reproduced.

MD-Settings - Edit Page "Save" button is called "save" and issue is fixed. Attached screencast for reference.

Adding Te-Verified labels .

Thanks!
689093.mp4
736 KB View Download
Status: Verified (was: Fixed)
Verified on ChromeOS 9334.0.0 / 58.0.3028.0

Sign in to add a comment