New issue
Advanced search Search tips

Issue 689092 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Feature Request: Add "stop" label to make debugging easier

Reported by evensten...@gmail.com, Feb 6 2017

Issue description

Chrome Version       : 55.0.2883.95
OS Version: OS X 10.12.2
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Produce an consistent error which will throw regularly
2. Watch the console get filled

What is the expected result?

Expected result is as expected


Please provide any additional information below. Attach a screenshot if
possible.

Hi! When doing development with React and some work at NASA/openmct now and then, I've been sometimes implementing code that makes the applications go into frenzy with errors. I know there is a possibility to use the debugger and pause on exceptions, but sometimes that isn't gonna cut it. 

Example: 

If you use setState within a render method in React, you'll get overthrown by the warning messages thrown as errors ( invariants ) when running your application. Sometimes to prevent this from happening, thus not in this case, you'd like to see some code you log inside, in this instance; the render method. It's possible to get an console log within this pattern, but the errors make to much noise and at some point crashes the application instance. 

From a developers perspective, I'd rather want to stop the noise for a minute while looking what I'm getting into the state, than a bunch of errors. The bug might also be cause of an object getting wrong properties or something else from userland, but I know for sure that I want to be able to partly get information about this so I could better understand the problem ( if I didn't know where it was coming from ).

React has handled this error in some sub-version of v.15, but the error is consistent across all developers. I can more or less likely say that I'm not the only one that wants to do this instead of getting my browser crashed, having to ability to debug my application.

I want to work on this along with Konrad Dzwinel if you're open to a Pull Request. This issue needs some discussion though, (look at next section for info) cause if we only delete the error messages, there would still be an issue on the VM if we don't somehow skip the code validation when we see where the error origins from.

Thoughts on implementation:

1. Make a stop label that is clickable in the console tab. 
2. If the user clicks the button, the same errors being thrown between some interval is being discarded.
3. Step 2 needs to be discussed, cause we can benefit if we see the same error being thrown developer wise ( me looking at the chromium source ), but if its different errors that cause the overflow, we might as well support stopping the logging completely from when the user enables the "stop" label and disables it.

Let me know your thoughts, added a visual so you can get a grasp of what I'm thinking visually!

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36



 
Skjermbilde 2017-02-06 kl. 18.42.36.png
216 KB View Download
Labels: -Type-Bug Needs-Milestone OS-Linux OS-Windows Type-Feature
Status: Untriaged (was: Unconfirmed)
Thanks for the report, considering this as Feature request marking as Untriaged Requesting Dev team to check the issue and update accordingly.
Labels: -Needs-Milestone M-59
I'm happy to work on this if you want it implemented :) 
Components: Platform>Apps>DevTools

Sign in to add a comment