Simple chrome should check default args.gn |
||||||||
Issue descriptionIn the Simple Chrome documentation: http://dev.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromium-browser#TOC-Build-Chromium We rely on a manual gn gen step: gn gen out_$SDK_BOARD/Release --args="$GN_ARGS" However, if the gn configuration changes (which should be rare), or the developer changes the flags passed to 'cros chrome-sdk', e.g. '--internal', we do not detect whether or not 'gn gen' needs to be rerun. This is a little bit tricky because not all developers will use the suggested output directory (out_$SDK_BOARD/Release) and some will intentionally modify the configuration. We could however check for the existnce and compare the contents of args.gn in out_$SDK_BOARD/Release to the output of 'gn gen' and display a status message to the developer.
,
Apr 10 2017
,
Apr 12 2017
,
May 9 2017
when/if we do this we should also set CHROMIUM_OUT_DIR, see issue 407417 for details.
,
May 16 2017
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2521c6c91ed506e97351ae0a619ec27a76dff299 commit 2521c6c91ed506e97351ae0a619ec27a76dff299 Author: C Shapiro <shapiroc@google.com> Date: Thu May 18 02:06:25 2017 Check for stale args.gn on cros chrome-sdk If the user has previously run: gn gen out_$SDK_BOARD/Release --args="$GN_ARGS" Every time the user calls cros chrome-sdk --board=$BOARD The script will now check to see if the generated args.gn file is stale and will warn the user if the file is stale. This also now sets the CHROMIUM_OUT_DIR env variable to the board output directory. BUG= chromium:689090 TEST=unit test and verify locally using cros chrome-sdk --internal Change-Id: I59815eae1f6d82df1c66886f20c2ce85feacacdf Reviewed-on: https://chromium-review.googlesource.com/507927 Commit-Ready: C Shapiro <shapiroc@google.com> Tested-by: C Shapiro <shapiroc@google.com> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/2521c6c91ed506e97351ae0a619ec27a76dff299/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/2521c6c91ed506e97351ae0a619ec27a76dff299/cli/cros/cros_chrome_sdk_unittest.py
,
May 18 2017
Woo hoo! Glad to see this happened.
,
May 18 2017
,
Jun 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/fa366fbb1a9536748ff4b6a19bbe80bd7019c7c0 commit fa366fbb1a9536748ff4b6a19bbe80bd7019c7c0 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Jun 20 20:38:10 2017 cros_chrome_sdk: Ignore changes to non critical GN args This adds a list of args.gn values to ignore when comparing to the GN_ARGS specified in the SKD environment. It also includes info level debugging for differences to the args. BUG= chromium:689090 TEST=cli/cros/cros_chrome_sdk_unittest Change-Id: If5dff1b92d1283e62e6061e044b9d7a7ad5009f0 Reviewed-on: https://chromium-review.googlesource.com/538038 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/fa366fbb1a9536748ff4b6a19bbe80bd7019c7c0/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/fa366fbb1a9536748ff4b6a19bbe80bd7019c7c0/cli/cros/cros_chrome_sdk_unittest.py
,
Jul 5 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by derat@chromium.org
, Feb 9 2017Status: Assigned (was: Available)