New issue
Advanced search Search tips

Issue 689085 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 603386


Show other hotlists

Hotlists containing this issue:
MacViews-Task-Queue


Sign in to add a comment

MacViews: Decouple Task Manager from md-secondary-ui flag

Project Member Reported by shrike@chromium.org, Feb 6 2017

Issue description

Right now if you enable the md-secondary-ui flag to turn on Views in browser secondary ui, the Task Manager is also converted to Views. If we do ship the Task Manager in Views it won't be as part of Harmony Phase 1. The Task Manager needs its own flag for Views mode.

 
Status: Started (was: Assigned)
https://codereview.chromium.org/2679643003/
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b6ffe796dc5188894fa9a69bd7696a598ce5b1f

commit 9b6ffe796dc5188894fa9a69bd7696a598ce5b1f
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Feb 07 14:06:04 2017

macviews: unhook task manager from --secondary-ui-md

The task manager won't be included when we ship MacViews.

BUG= 689085 

Review-Url: https://codereview.chromium.org/2679643003
Cr-Commit-Position: refs/heads/master@{#448615}

[modify] https://crrev.com/9b6ffe796dc5188894fa9a69bd7696a598ce5b1f/chrome/browser/ui/cocoa/task_manager_mac.mm

Comment 3 by tapted@chromium.org, Feb 15 2017

Blocking: 603386
Labels: Phase3
Maybe fixed, but my OCD for go/macviewstracking is kicking in (this wasn't tracked).

We may also want to re-expose the task manager, but there is  Issue 670579  for that.
Status: Fixed (was: Started)

Sign in to add a comment