New issue
Advanced search Search tips

Issue 689076 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert OfflineAudioContext tests to testharness

Project Member Reported by rtoy@chromium.org, Feb 6 2017

Issue description

Update tests to use testharness
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aca6ce1196fca0dc0cca083b24be9b483f0dc3d

commit 8aca6ce1196fca0dc0cca083b24be9b483f0dc3d
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 14 21:09:04 2017

Convert OfflineAudioContext Audit tests to testharness

Used the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Still needed to convert manually some uses of testPassed/testFailed
and some old js-test functions.

BUG= 689076 
TEST=offlineaudiocontext-promise-basic.html,
offlineaudiocontext-suspend-resume-basic.html

Review-Url: https://codereview.chromium.org/2676343003
Cr-Commit-Position: refs/heads/master@{#450472}

[delete] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic-expected.txt
[modify] https://crrev.com/8aca6ce1196fca0dc0cca083b24be9b483f0dc3d/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html
[delete] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic-expected.txt
[modify] https://crrev.com/8aca6ce1196fca0dc0cca083b24be9b483f0dc3d/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7832d67481ad51c31126552301df007efb57fa8a

commit 7832d67481ad51c31126552301df007efb57fa8a
Author: rtoy <rtoy@chromium.org>
Date: Tue Feb 14 21:29:59 2017

Convert OfflineAudioContext tests to testharness

Manually convert these tests to testharness and new Audit.

BUG= 689076 
TEST=

Review-Url: https://codereview.chromium.org/2680033002
Cr-Commit-Position: refs/heads/master@{#450481}

[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-constructor-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-constructor.html
[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html
[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html
[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation.html
[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html
[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence.html
[delete] https://crrev.com/2b892c8633d4e17894340683093748d229dcd3e7/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange-expected.txt
[modify] https://crrev.com/7832d67481ad51c31126552301df007efb57fa8a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html

Status: Verified (was: Available)

Sign in to add a comment