Replace usage of STL clear() with base::STLClearObject() where appropriate |
||
Issue descriptionSimilar to Issue 684746 and Issue 620853 , STL clear() doesn't actually free memory used by std::string and containers. We need to do a pass of remaining usage in net/ and use base::STLClearObject() where appropriate.
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/247c7485836209481c53e865856ec7b8ef81178e commit 247c7485836209481c53e865856ec7b8ef81178e Author: xunjieli <xunjieli@chromium.org> Date: Mon Feb 06 17:52:58 2017 Use STLClearObject in URLFetcherCore URLFetcherCore can be reused for different requests. If it is used for a chunked upload following a non-chunked upload, we clear the previous non-chunked upload content by doing |upload_content_|.clear(). However this might not free up the memory used by |upload_content_|. This CL uses base::STLClearObject(). BUG= 689062 Review-Url: https://codereview.chromium.org/2680493002 Cr-Commit-Position: refs/heads/master@{#448297} [modify] https://crrev.com/247c7485836209481c53e865856ec7b8ef81178e/net/url_request/url_fetcher_core.cc
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3c226027ca052c366d9b425666ec4fe57aab22d commit c3c226027ca052c366d9b425666ec4fe57aab22d Author: xunjieli <xunjieli@chromium.org> Date: Wed Feb 08 14:03:10 2017 Use base::STLClearObject in QuicServerInfo std::string::clear() doesn't guarantee to free memory. This CL uses base::STLClearObject() in QuicServerInfo. See linked bug for more info. BUG= 689062 Review-Url: https://codereview.chromium.org/2678333003 Cr-Commit-Position: refs/heads/master@{#448983} [modify] https://crrev.com/c3c226027ca052c366d9b425666ec4fe57aab22d/net/quic/chromium/quic_server_info.cc
,
Aug 7 2017
Is there anything left to do before we close this bug?
,
Aug 7 2017
,
Jan 2 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 6 2017