New issue
Advanced search Search tips

Issue 689060 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

common.mk: Unit tests for non-native boards are not working

Project Member Reported by jorgelo@chromium.org, Feb 6 2017

Issue description

QEMU   Preparing qemu-arm
TEST		libminijail_unittest TEST		syscall_filter_unittest [SETUP]
[SETUP]
TEST		libminijail_unittest [RUN]
TEST		syscall_filter_unittest [RUN]
ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
unshare: cannot change root filesystem propagation: Invalid argument
ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
unshare: cannot change root filesystem propagation: Invalid argument
make[1]: [common.mk:524: TEST(CXX_BINARY(libminijail_unittest))] Error 1 (ignored)
TEST		libminijail_unittest [TEARDOWN]
make[1]: [common.mk:524: TEST(CXX_BINARY(syscall_filter_unittest))] Error 1 (ignored)
TEST		syscall_filter_unittest [TEARDOWN]
make[1]: *** [common.mk:524: TEST(CXX_BINARY(libminijail_unittest))] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [common.mk:524: TEST(CXX_BINARY(syscall_filter_unittest))] Error 1
make[1]: Leaving directory '/mnt/host/source/src/aosp/external/minijail'
make: *** [common.mk:171: TEST(CXX_BINARY(libminijail_unittest))] Error 2
 * ERROR: chromeos-base/chromeos-minijail-9999::chromiumos failed (test phase):
 *   emake failed
 
Owner: jorgelo@chromium.org
the ebuild needs updating.  using TEST will invoke the unittests now, so you need to delete the `./libminijail_unittest` parts and move the `emake` under the `use amd64` check.

you're correct that the qemu work in common.mk never fully finished, but that's because we finished in platform2.  i don't think there's much interest now to finish common.mk's qemu integration.
Status: WontFix (was: Untriaged)
Oh, I already did that in https://chromium-review.googlesource.com/c/438424/. I was filing this to have something to put in a TODO in that CL, but if this is not planned to be fixed, then I'll mark WontFix.
Summary: common.mk: Unit tests for non-native boards are not working (was: Unit tests for ARM boards are not working)
yeah we started to, but once we finished all the work in platform2_test, we looked back on the common.mk framework and saw that there's quite a lot we'd need to add back for it to be sane

perhaps we should just delete it now

Sign in to add a comment