New issue
Advanced search Search tips

Issue 689035 link

Starred by 1 user
Status: Verified
Owner:
tandrii@chromium.org
Closed: Feb 2017
Cc:
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 685318



Sign in to add a comment

git cl upload for gerrit doesn't honor the git cache properly

Project Member Reported by machenb...@chromium.org, Feb 6 2017 
See https://chromium-review.googlesource.com/c/438328

Auto roller tries:
git cl upload -f --use-commit-queue --bypass-hooks --email v8-autoroll@chromium.org --send-mail --gerrit

But gerrit tries to push to git cache. See e.g.:
https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/Auto-roll%20-%20v8%20deps/builds/663

Comment 2 by tandrii@chromium.org, Feb 6 2017

Labels: Milestone-Dogfood Proj-Gerrit-Migration
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/e9c78ffc95a4f9376e61c741f5c27603c26a6c8c

commit e9c78ffc95a4f9376e61c741f5c27603c26a6c8c
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Feb 06 15:07:43 2017

git cl for Gerrit: add support for local git cache checkouts.

R=machenbach@chromium.org
BUG= 689035 

Change-Id: Ib7a56c52501a5d0dd6638a99bde3d376bd27bfb6
Reviewed-on: https://chromium-review.googlesource.com/438347
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/e9c78ffc95a4f9376e61c741f5c27603c26a6c8c/tests/git_cl_test.py
[modify] https://crrev.com/e9c78ffc95a4f9376e61c741f5c27603c26a6c8c/git_cl.py
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b775ec987d5d090ab720ec2c080d0de110efdeee

commit b775ec987d5d090ab720ec2c080d0de110efdeee
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Feb 06 15:17:59 2017

Revert "Revert "V8: Switch deps roller to gerrit""

This reverts commit 48b52a216d945c0b783b63642d4a4f7b87004eb1.

Reason for revert:  Issue 689035  fixed.

Original change's description:
> Revert "V8: Switch deps roller to gerrit"
> 
> This reverts commit f2f81bc7ea2050cf37e8362fec123116c6c2e8b4.
> 
> Reason for revert: The bot uses git cache and git cl upload uses the wrong origin in the cache for pushing to gerrit.
> 
> Original change's description:
> > V8: Switch deps roller to gerrit
> > 
> > BUG= 685318 
> > 
> > Change-Id: Ib33883097557693bfe82c82880c66611ca9d2f37
> > Reviewed-on: https://chromium-review.googlesource.com/438325
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> > 
> 
> TBR=machenbach@chromium.org,hablich@chromium.org,tandrii@chromium.org,agable@chromium.org,chromium-reviews@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 685318 
> 
> Change-Id: Id48ee1663dad7b926d58959c9095818dc6ce241b
> Reviewed-on: https://chromium-review.googlesource.com/438328
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> 

TBR=agable@chromium.org,machenbach@chromium.org,hablich@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 685318 , 689035 

Change-Id: If26f9d66be6fb9c5a6fff9c13486d36a91126c56
Reviewed-on: https://chromium-review.googlesource.com/438404
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/b775ec987d5d090ab720ec2c080d0de110efdeee/scripts/slave/recipes/v8/auto_roll_v8_deps.expected/roll.json
[modify] https://crrev.com/b775ec987d5d090ab720ec2c080d0de110efdeee/scripts/slave/recipes/v8/auto_roll_v8_deps.py

Comment 7 by machenb...@chromium.org, Feb 6 2017

Status: Verified (was: Fixed)
Seems to work! Thanks!
►

Sign in to add a comment