New issue
Advanced search Search tips

Issue 689000 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Use displayName as a display name

Project Member Reported by rsorokin@chromium.org, Feb 6 2017

Issue description

net ads search .... | grep displayName
 
also net ads search .... | grep givenName
user user::set_display_name and user::set_given_name
actually UserManager::UpdateUserAccountData
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/cc0eda812a8aaa665d4f26f5da74875284849bf6

commit cc0eda812a8aaa665d4f26f5da74875284849bf6
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Thu Feb 09 20:47:42 2017

authpolicy: Add active_directory_account_data.proto

It will be used to report to chrome Active Directory account info

BUG= chromium:689000 
TEST=manual

Change-Id: I024508681f9b284a6a3187db1469a690dd930b7f
Reviewed-on: https://chromium-review.googlesource.com/439565
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/cc0eda812a8aaa665d4f26f5da74875284849bf6/system_api.gyp
[add] https://crrev.com/cc0eda812a8aaa665d4f26f5da74875284849bf6/dbus/authpolicy/active_directory_account_data.proto

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75c0f221319bcb8d6ca558c886299cbbfee57d3d

commit 75c0f221319bcb8d6ca558c886299cbbfee57d3d
Author: rsorokin <rsorokin@chromium.org>
Date: Fri Feb 10 12:17:55 2017

Upprev cros_system_api

BUG= 689000 

Review-Url: https://codereview.chromium.org/2687303002
Cr-Commit-Position: refs/heads/master@{#449597}

[modify] https://crrev.com/75c0f221319bcb8d6ca558c886299cbbfee57d3d/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc75ccee5fbb2fb80fe9981b38ea122180500c43

commit fc75ccee5fbb2fb80fe9981b38ea122180500c43
Author: rsorokin <rsorokin@chromium.org>
Date: Fri Feb 10 13:16:43 2017

Chromad: Wire up displayName and givenName

Send to Chromium displayName and givenName fetched from Active Directory

BUG= 689000 
TEST=manual

Review-Url: https://codereview.chromium.org/2685793004
Cr-Commit-Position: refs/heads/master@{#449602}

[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/app_launch_signin_screen.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/existing_user_controller.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/ui/login_display.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/ui/webui_login_display.cc
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/chromeos/login/ui/webui_login_display.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chromeos/BUILD.gn
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/fc75ccee5fbb2fb80fe9981b38ea122180500c43/chromeos/dbus/fake_auth_policy_client.cc

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/047d3689430e38354b309a07225134850d6d0232

commit 047d3689430e38354b309a07225134850d6d0232
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Sat Feb 25 12:19:52 2017

system_api: Add system_api-authpolicy-protos library to linker options

BUG= chromium:689000 
TEST=manual

Change-Id: Ie20827b99d7ab03ba2091b90f29aaef22c234fd5
Reviewed-on: https://chromium-review.googlesource.com/446337
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/047d3689430e38354b309a07225134850d6d0232/system_api.pc

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e0f7b8ba22687eb3d84896beff7827d86efbcdf8

commit e0f7b8ba22687eb3d84896beff7827d86efbcdf8
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Mon Feb 27 20:03:23 2017

system_api: Add authpolicy dir to copy *.h files from

BUG= chromium:689000 
TEST=manual

Change-Id: I273dfc28edf96094880994c945108abfdea8c98c
Reviewed-on: https://chromium-review.googlesource.com/445904
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/e0f7b8ba22687eb3d84896beff7827d86efbcdf8/chromeos-base/system_api/system_api-9999.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7f9aec6c8f5735d1925388f334b0be2e0f53ceef

commit 7f9aec6c8f5735d1925388f334b0be2e0f53ceef
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed Mar 01 21:19:49 2017

authpolicy: Parse and report displayName and givenName

Both attributes are returned from AuthenticateUser D-Bus call. Used in
Chromium UI.

BUG= chromium:689000 
TEST=manual
CQ-DEPEND=CL:439565,CL:446337,CL:445904

Change-Id: Ie166a3bebc7ace693a82909a141fadfd06cd310f
Reviewed-on: https://chromium-review.googlesource.com/439187
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/authpolicy.gyp
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/authpolicy.h
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/authpolicy_parser_main.cc
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/samba_interface.cc
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/samba_interface.h
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/authpolicy.cc
[modify] https://crrev.com/7f9aec6c8f5735d1925388f334b0be2e0f53ceef/authpolicy/proto/authpolicy_containers.proto

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3c4f6da7cbc226e293bcc14588ed586126a3fd

commit fb3c4f6da7cbc226e293bcc14588ed586126a3fd
Author: rsorokin <rsorokin@chromium.org>
Date: Tue Mar 21 14:47:16 2017

AuthPolicyClient: Remove fallback for D-Bus response.

D-Bus interface response switched from string to protobuf.
We had fallback to string during transition period.

BUG= 689000 
TEST=manual

Review-Url: https://codereview.chromium.org/2726133003
Cr-Commit-Position: refs/heads/master@{#458408}

[modify] https://crrev.com/fb3c4f6da7cbc226e293bcc14588ed586126a3fd/chromeos/dbus/auth_policy_client.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/58fb48d2c1ad786dd6ac0bc611aec72c27b5820f

commit 58fb48d2c1ad786dd6ac0bc611aec72c27b5820f
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Sat Mar 25 02:38:19 2017

authpolicy: Don't fail if displayName or givenName could not be found

BUG= chromium:689000 
TEST=manual

Change-Id: Ie3fe310f1ba60e805cece27d8dbddf3a7d824ad3
Reviewed-on: https://chromium-review.googlesource.com/452505
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/58fb48d2c1ad786dd6ac0bc611aec72c27b5820f/authpolicy/authpolicy_parser_main.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment