New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 688983 link

Starred by 1 user
Status: WontFix
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
bettes@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [MD Settings] Focus on toggle buttons are not aligned properly.

Reported by dchau...@etouch.net, Feb 6 2017 
Chrome Version: 58.0.3004.0 (Official Build) 604a36b20d9ffe65380031f3f708d859d81f71be-refs/heads/master@{#448183} 32/64-bit.
OS: Windows(7,8,10),Mac(10.12.1, 10.11.6, 10.12),Linux 14.04.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings page.
2. Keep focus on any toggle button using 'Tab' key and observe.

Focus on toggle button is not center aligned.
Focus on toggle button should center aligned.

This is regression issue, broken in ‘M-58’ and below is manual bisect info:

Good build: 58.0.2998.0
Bad build: 58.0.2999.0

Kindly review the attached screen-cast for reference.
Toggle button Screenshot.png
3.1 KB View Download
Actual behavior.mp4
712 KB View Download
Expected behavior.mp4
344 KB View Download

Comment 1 by kkaluri@chromium.org, Feb 6 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 58.0.2998.0,  Revision Range - 447146
Bad build  : 58.0.2999.0,  Revision Range - 447413

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/b6f1374b024b68b909ffb632b5a8c184391476bf..a2176d0c08e0a2367c91c2edb8ae255f185130ae

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a2176d0c08e0a2367c91c2edb8ae255f185130ae

Review-Url: https://codereview.chromium.org/2656563006

scottchen@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by scottchen@chromium.org, Feb 8 2017

Cc: bettes@chromium.org
Status: WontFix (was: Assigned)
This is working as intended. The new look is the result of two changes that brings the toggle element to bettes@'s spec:
- changing the size of ripple from 48px to 40px.
- lengthening the toggle-bar.
►

Sign in to add a comment