New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688979 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

rose support

Project Member Reported by rongchang@chromium.org, Feb 6 2017

Issue description

Add rose (host signal processing board) firmware support.

This board has an stm32f412 mcu and SPI heatmap measurement. It supports data acquisition via I2C.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/e388e9c74673d7c64cb791437858978bf2a3a142

commit e388e9c74673d7c64cb791437858978bf2a3a142
Author: Rong Chang <rongchang@google.com>
Date: Tue Mar 28 18:27:57 2017

rose: add stm32f4 family support

This change applys config-stm32f446.h to stm32f4 family.

BUG=chromium:688979
TEST=boots on stm32f401 and stm32f412 dev boards
BRANCH=none

Change-Id: I939fd17f29f4b431d9c1358c184166c67fef18d3
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/438908
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/e388e9c74673d7c64cb791437858978bf2a3a142/chip/stm32/config_chip.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/86397ec144dcad7f23635b0f1397ae4a015162bb

commit 86397ec144dcad7f23635b0f1397ae4a015162bb
Author: Rong Chang <rongchang@google.com>
Date: Wed Apr 26 18:25:57 2017

rose: enable stm32f4 EXTI IRQs

This change copied gpio_init() from stm32f373 driver.

BUG=chromium:688979
TEST=load on dev board and check button interrupt
BRANCH=none

Change-Id: I9dc12ffc02899211b6d07a640682899654c2bbed
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/438909
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/86397ec144dcad7f23635b0f1397ae4a015162bb/chip/stm32/gpio-stm32f4.c

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/3e68c64dfd7be4e5819bdc3ff9019cc5718c9f02

commit 3e68c64dfd7be4e5819bdc3ff9019cc5718c9f02
Author: Rong Chang <rongchang@google.com>
Date: Wed Apr 26 18:25:57 2017

rose: remove dependency between stm32f4 I2C master and slave drivers

Frequency change hooks are needed in I2C master mode only.

BUG=chromium:688979
TEST=remove CONFIG_I2C_MASTER and build rose target
BRANCH=none

Change-Id: I7244af73f97799d396d8680c8f131e8746a56e18
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/438910
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org>

[modify] https://crrev.com/3e68c64dfd7be4e5819bdc3ff9019cc5718c9f02/chip/stm32/i2c-stm32f4.c

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/9807e01760cef5c0f5e158f59c0bf36b063916ed

commit 9807e01760cef5c0f5e158f59c0bf36b063916ed
Author: Rong Chang <rongchang@google.com>
Date: Wed Apr 26 18:25:58 2017

rose: add stm32f4 SPI master support

This change adds stm32f4 stream DMA support and a config option to use
first SPI port as master.

BUG=chromium:688979
TEST=build and load on stm32f4 dev board
BRANCH=none

Change-Id: I2b504be70e0fbb17f16ce070119ae4715c88333a
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/438911
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/9807e01760cef5c0f5e158f59c0bf36b063916ed/chip/stm32/registers.h
[modify] https://crrev.com/9807e01760cef5c0f5e158f59c0bf36b063916ed/chip/stm32/spi_master.c
[modify] https://crrev.com/9807e01760cef5c0f5e158f59c0bf36b063916ed/include/config.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/ee28ccb0ca0a76ff3c097471ba7732facf404663

commit ee28ccb0ca0a76ff3c097471ba7732facf404663
Author: Rong Chang <rongchang@google.com>
Date: Wed Apr 26 18:25:58 2017

rose: stm32f4: fix DMA macro to get ISR bits

Rose reads heatmap via halfduplex SPI sensors. This change fixed the
macro to get correct DMA ISR register.

BUG=chromium:688979
TEST=manually run spixfer in EC console and check return value
BRANCH=none

Change-Id: I303bdb483032c02d01fd322095f17dba37555447
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/444631
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/ee28ccb0ca0a76ff3c097471ba7732facf404663/chip/stm32/registers.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/e5a4d4746174919c9a1bc0cd567ee19c0f9740ea

commit e5a4d4746174919c9a1bc0cd567ee19c0f9740ea
Author: Rong Chang <rongchang@google.com>
Date: Thu May 18 13:03:50 2017

stm32f4: Add stm32f4 I2C slave driver

This patch clones I2C slave and hostcmd driver from stm32f0.

This patch contains contribution from Wei-Ning Huang <wnhuang@chromium.org>
for fixing i2c slave transmitter (CL:471726).

BUG=chromium:688979
TEST=build and load on dev board, run i2cget/set on host and check
     return value.
BRANCH=none

Change-Id: I3d159d5bdd4bda6c229cf6d275ab4982836628dc
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/461037
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org>

[modify] https://crrev.com/e5a4d4746174919c9a1bc0cd567ee19c0f9740ea/chip/stm32/registers.h
[modify] https://crrev.com/e5a4d4746174919c9a1bc0cd567ee19c0f9740ea/chip/stm32/i2c-stm32f4.c
[modify] https://crrev.com/e5a4d4746174919c9a1bc0cd567ee19c0f9740ea/include/config.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/b3d0d05aa954bc633deb00f82e40f79f889ca661

commit b3d0d05aa954bc633deb00f82e40f79f889ca661
Author: Rong Chang <rongchang@google.com>
Date: Mon May 22 12:02:46 2017

rose: spi: add SPI master halfduplex mode

This change adds 3-wire mode support in STM32 SPI master driver.

BUG=chromium:688979
TEST=manual
     enable CONFIG_SPI_HALFDUPLEX
     read id from SPI heatmap sensor
BRANCH=none

Change-Id: I09139dcbfe39a427721451db6842ea712abf2e33
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/444630
Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/b3d0d05aa954bc633deb00f82e40f79f889ca661/chip/stm32/spi_master.c
[modify] https://crrev.com/b3d0d05aa954bc633deb00f82e40f79f889ca661/include/config.h

Sign in to add a comment