[Remote suggestions] Split up data usage: keep json fetching and thumbnail fetching separate |
||||||
Issue descriptionCurrently, we have only one data usage bucket in which we register all fetches. We should separate: - json fetching (in the background) from - thumbnail images fetching (on demand).
,
Feb 7 2017
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd18da6b82c146850fc2a10700ae89e1f21e329a commit cd18da6b82c146850fc2a10700ae89e1f21e329a Author: jkrcal <jkrcal@chromium.org> Date: Fri Feb 10 07:53:50 2017 [Remote suggestions] Measure separate data use for JSONs and thumbnails Before this CL, these two cases are measured in one DataUseUserData enum element. This CL adds another enum element and renames the previous one for better clarity. It is important to split the measurements in order to get clearer insights because there are of very different nature: - The JSONs are background data that is used for every user (to some extent) independently of usage of Chrome. - On the other hand, the thumbnails are loaded on demand only when the feature is used. BUG= 688945 Review-Url: https://codereview.chromium.org/2685523002 Cr-Commit-Position: refs/heads/master@{#449563} [modify] https://crrev.com/cd18da6b82c146850fc2a10700ae89e1f21e329a/components/data_use_measurement/core/data_use_user_data.cc [modify] https://crrev.com/cd18da6b82c146850fc2a10700ae89e1f21e329a/components/data_use_measurement/core/data_use_user_data.h [modify] https://crrev.com/cd18da6b82c146850fc2a10700ae89e1f21e329a/components/ntp_snippets/remote/json_request.cc [modify] https://crrev.com/cd18da6b82c146850fc2a10700ae89e1f21e329a/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc [modify] https://crrev.com/cd18da6b82c146850fc2a10700ae89e1f21e329a/tools/metrics/histograms/histograms.xml
,
Feb 20 2017
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/291cbdce8960e700e68675fc32258dec3095ae82 commit 291cbdce8960e700e68675fc32258dec3095ae82 Author: jkrcal <jkrcal@chromium.org> Date: Fri Mar 03 21:41:54 2017 [Remote suggestions] Add DataUse.MessageSize suffixes. This CL fixes a minor ommision in CL 2685523002. BUG= 688945 Review-Url: https://codereview.chromium.org/2726223003 Cr-Commit-Position: refs/heads/master@{#454684} [modify] https://crrev.com/291cbdce8960e700e68675fc32258dec3095ae82/tools/metrics/histograms/histograms.xml
,
Mar 6 2017
I would like to merge the latter CL. Only a metrics change. Needed to better analyze how much data we use on the NTP.
,
Mar 6 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b53294ae2e72ca0d3e3d75c379fd2c6b4a739892 commit b53294ae2e72ca0d3e3d75c379fd2c6b4a739892 Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Mar 06 08:29:29 2017 [Remote suggestions] Add DataUse.MessageSize suffixes. This CL fixes a minor ommision in CL 2685523002. BUG= 688945 Review-Url: https://codereview.chromium.org/2726223003 Cr-Commit-Position: refs/heads/master@{#454684} (cherry picked from commit 291cbdce8960e700e68675fc32258dec3095ae82) Review-Url: https://codereview.chromium.org/2728333002 . Cr-Commit-Position: refs/branch-heads/3029@{#16} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/b53294ae2e72ca0d3e3d75c379fd2c6b4a739892/tools/metrics/histograms/histograms.xml |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fi...@chromium.org
, Feb 6 2017