Issue 688943 link

Starred by 4 users

Issue metadata

Status:	Fixed
Owner:	pwnall@chromium.org
Closed:	Mar 2017
Cc:	jsb...@chromium.org foolip@chromium.org pwnall@chromium.org █ dk...@chromium.org
Components:	Blink>DataTransfer
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	2
Type:	Launch-OWP
Launch-Accessibility:	NA
Launch-Exp-Leadership:	----
Launch-Leadership:	----
Launch-Legal:	NA
Launch-M-Approved:	----
Launch-M-Target:	58-Beta
Launch-Privacy:	NA
Launch-Security:	NA
Launch-Test:	----
Launch-UI:	NA
Rollout-Type:	----
OWP-Design-No OWP-Standards-ChromeOnly Hotlist-Merge-Approved OWP-Type-Deprecation M-58 merge-merged-3029

Blocking:
issue 674593

Deprecate and remove webkitdropzone

Project Member Reported by pwnall@chromium.org, Feb 6 2017

Issue description

Change description:
I want to remove a prefixed HTML global attribute, webkitdropzone. The standard version of the attribute (dropzone) failed to gain traction among browsers. Our own implementation has been broken in a meaningful way (could not accept dragged files on http: and https: origins), and nobody noticed. Therefore, I want to remove support for this attribute quickly, to make sure that Web content doesn't begin to depend on it.

Changes to API surface:
Remove support for the non-standard webkitdropzone global attribute.

Links:
Public standards discussion: N/A, this is a non-standard global attribute

Support in other browsers:
Internet Explorer: no
Firefox: no
Safari: yes

*Make sure to fill in any labels with a -?, including all OSes this change
affects. Feel free to leave other labels at the defaults.

Comment 1 by pwnall@chromium.org, Feb 6 2017

Components: Blink>DataTransfer
Labels: Launch-Privacy-NA Launch-Security-NA

Comment 2 by pwnall@chromium.org, Feb 6 2017

Cc: pwnall@chromium.org

 Issue 674328  has been merged into this issue.

Comment 3 by foolip@chromium.org, Feb 8 2017

Blocking: 674593

Comment 4 by pwnall@chromium.org, Feb 28 2017

Intent thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/rdGvTDPU7mM/discussion
Chromestatus entry: https://www.chromestatus.com/feature/5718005866561536

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2

commit 798a0d0b8b42492f3acd803caa2ce0b35b8b29d2
Author: pwnall <pwnall@chromium.org>
Date: Fri Mar 03 03:06:50 2017

Remove webkitdropzone.

webkitdropzone is a prefixed version of the dropzone HTML global
attribute. dropzone failed to gain traction among browser vendors, and
only Blink and WebKit implement prefixed versions. Therefore, dropzone
is being removed from the HTML specification in
https://github.com/whatwg/html/pull/2402

The following LayoutTests, which depended on webkitdropzone, have been
rewritten to use event listeners. These tests cover other drag-and-drop
functionality that we still want covered.

* fast/events/dropzone-001 -> fast/dnd/dropEffect-for-effectAllowed
* fast/events/dropzone-002 -> fast/dnd/dropEffect-for-image
* fast/events/dropzone-003 -> fast/dnd/dropEffect-for-link
* fast/events/dropzone-004 -> fast/dnd/dropEffect-for-file

The followng LayoutTests have been removed, because they do not cover
additional functionality that we still need.

* fast/events/dropzone-005 -> only covers dropzone-specific code
* fast/dnd/file-drop-on-webkitdropzone-element.html -> redundant with
  fast/dnd/file-drag-drop-on-page.html
* http/tests/dnd/file-drop-on-webkitdropzone-element.html -> redundant with
  fast/dnd/file-drag-drop-on-page.html

BUG= 688943 

Review-Url: https://codereview.chromium.org/2720463002
Cr-Commit-Position: refs/heads/master@{#454488}

[add] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html
[add] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-file.html
[add] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-image.html
[add] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/dnd/file-drop-on-webkitdropzone-element.html
[add] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/fast/dnd/resources/dropEffect-common.js
[add] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/fast/dnd/resources/greenbox.png
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-001-expected.txt
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-001.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-002-expected.txt
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-002.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-003-expected.txt
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-003.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-004-expected.txt
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-004.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-005-expected.txt
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/fast/events/dropzone-005.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/http/tests/dnd/drop-file-on-webkitdropzone.html
[delete] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/http/tests/dnd/resources/dragged-file.txt
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/Source/core/html/HTMLElement.idl
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/798a0d0b8b42492f3acd803caa2ce0b35b8b29d2/tools/metrics/histograms/histograms.xml

Comment 6 by pwnall@chromium.org, Mar 3 2017

Status: Fixed (was: Assigned)

Comment 7 by pwnall@chromium.org, Mar 5 2017

Labels: Merge-Request-58 Launch-M-Target-58-Beta
Status: Started (was: Fixed)

Ah, this landed a few commits past the M58 branch point.

Project Member

Comment 8 by sheriffbot@chromium.org, Mar 5 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 5 2017

Labels: -merge-approved-58 merge-merged-3029

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b152fa718af332bde2004d61e5b0ecbef9653ec1

commit b152fa718af332bde2004d61e5b0ecbef9653ec1
Author: Victor Costan <pwnall@chromium.org>
Date: Sun Mar 05 06:52:33 2017

Remove webkitdropzone.

webkitdropzone is a prefixed version of the dropzone HTML global
attribute. dropzone failed to gain traction among browser vendors, and
only Blink and WebKit implement prefixed versions. Therefore, dropzone
is being removed from the HTML specification in
https://github.com/whatwg/html/pull/2402

The following LayoutTests, which depended on webkitdropzone, have been
rewritten to use event listeners. These tests cover other drag-and-drop
functionality that we still want covered.

* fast/events/dropzone-001 -> fast/dnd/dropEffect-for-effectAllowed
* fast/events/dropzone-002 -> fast/dnd/dropEffect-for-image
* fast/events/dropzone-003 -> fast/dnd/dropEffect-for-link
* fast/events/dropzone-004 -> fast/dnd/dropEffect-for-file

The followng LayoutTests have been removed, because they do not cover
additional functionality that we still need.

* fast/events/dropzone-005 -> only covers dropzone-specific code
* fast/dnd/file-drop-on-webkitdropzone-element.html -> redundant with
  fast/dnd/file-drag-drop-on-page.html
* http/tests/dnd/file-drop-on-webkitdropzone-element.html -> redundant with
  fast/dnd/file-drag-drop-on-page.html

BUG= 688943 

Review-Url: https://codereview.chromium.org/2720463002
Cr-Commit-Position: refs/heads/master@{#454488}
(cherry picked from commit 798a0d0b8b42492f3acd803caa2ce0b35b8b29d2)

Review-Url: https://codereview.chromium.org/2729353002 .
Cr-Commit-Position: refs/branch-heads/3029@{#9}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[add] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-effectAllowed.html
[add] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-file.html
[add] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-image.html
[add] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-link.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/dnd/file-drop-on-webkitdropzone-element.html
[add] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/fast/dnd/resources/dropEffect-common.js
[add] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/fast/dnd/resources/greenbox.png
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-001-expected.txt
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-001.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-002-expected.txt
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-002.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-003-expected.txt
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-003.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-004-expected.txt
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-004.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-005-expected.txt
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/fast/events/dropzone-005.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/http/tests/dnd/drop-file-on-webkitdropzone.html
[delete] https://crrev.com/1a6ab9428d8231516d5c861b68588c81f30bce4d/third_party/WebKit/LayoutTests/http/tests/dnd/resources/dragged-file.txt
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/Source/core/html/HTMLElement.idl
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/b152fa718af332bde2004d61e5b0ecbef9653ec1/tools/metrics/histograms/histograms.xml

Comment 10 by pwnall@chromium.org, Mar 5 2017

Status: Fixed (was: Started)

Comment 11 by foolip@chromium.org, Apr 7 2017

Cc: foolip@chromium.org

►

Issue 688943 link

Issue metadata

Deprecate and remove webkitdropzone

Issue description

Comment 1 by pwnall@chromium.org, Feb 6 2017

Comment 1 Deleted

Comment 2 by pwnall@chromium.org, Feb 6 2017

Comment 2 Deleted

Comment 3 by foolip@chromium.org, Feb 8 2017

Comment 3 Deleted

Comment 4 by pwnall@chromium.org, Feb 28 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Mar 3 2017

Comment 5 Deleted

Comment 6 by pwnall@chromium.org, Mar 3 2017

Comment 6 Deleted

Comment 7 by pwnall@chromium.org, Mar 5 2017

Comment 7 Deleted

Comment 8 by sheriffbot@chromium.org, Mar 5 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Mar 5 2017

Comment 9 Deleted

Comment 10 by pwnall@chromium.org, Mar 5 2017

Comment 10 Deleted

Comment 11 by foolip@chromium.org, Apr 7 2017

Comment 11 Deleted

Sign in to add a comment