New issue
Advanced search Search tips

Issue 688940 link

Starred by 1 user
Status: Verified
Owner:
azurewei@chromium.org
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Opt-in IME menu has no IMEs listed.

Project Member Reported by azurewei@chromium.org, Feb 6 2017 
Chrome Version: 58.0.3004.0
OS: Chrome

What steps will reproduce the problem?
(1) Open "Languages and input" settings page. 
(2) Check "Show input options in the shelf" checkbox.
(3) Open opt-in IME menu.

What is the expected result?
Opt-in IME menu lists the current selected IMEs in system.

What happens instead?
No IMEs listed.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
no-ime-listed.png
6.8 KB View Download

Comment 1 by tdander...@chromium.org, Feb 6 2017

Labels: -Type-Bug Proj-MaterialDesign-CrOS ReleaseBlock-Beta M-58 Type-Bug-Regression
Status: Started (was: Assigned)
Is this an M-58-only regression (or should this be targeted to a merge back to M-57 too?)

Also does this bug reproduce for the IME detailed view too?
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb

commit d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb
Author: azurewei <azurewei@chromium.org>
Date: Tue Feb 07 02:15:48 2017

ImeMenuListView is the subclass of ImeListView. ImeListView calls
Layout() in constructor, which is override by ImeMenuListView. There's
no guarantee that the ImeMenuListView::Layout() has been called.

Add ImeListView::Init() method for initializing the layout. Make the
constructor simple by moving out all the updating layout logic. And
call ImeListView::Init() after the instance created to make sure the
overridden method has been called.

Also, move down the title label by 2px.

BUG= 688940 
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2673333002
Cr-Commit-Position: refs/heads/master@{#448513}

[modify] https://crrev.com/d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/d0cea0b2ad6f139ecd443d5b2ccd3fa7d1bfc3eb/ash/common/system/ime/tray_ime_chromeos.cc

Comment 3 by azurewei@chromium.org, Feb 10 2017 

It should be M-58-only since I didn't repo this bug with M-57.

And it only reproduces with opt-in IME menu, since it's caused by ImeMenuListView which is for opt-in IME menu only.

Comment 4 by azurewei@chromium.org, Feb 10 2017

Status: Fixed (was: Started)

Comment 5 by son...@google.com, Apr 19 2017

Status: Verified (was: Fixed)
Verified on build 9334.52.0
►

Sign in to add a comment