New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688938 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Search icon appears to be misplaced in "www.icc-cricket.com"

Reported by adha...@etouch.net, Feb 6 2017

Issue description

Chrome Version: 58.0.3004.0 (Official Build) 604a36b20d9ffe65380031f3f708d859d81f71be-refs/heads/master@{#448183} (32/64-bit)
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to https://www.icc-cricket.com/
(2)Resize the browser window,click on Maximize button.
(3)Observe Search icon at the top R.H.S of the page.(Kindly refer the video)


Actual:Search icon does not appear to be proper.i.e appears misplaced. 

Expected:Search icon should appear properly.

This is a Regression issue broken in M-57,will soon update other info.

Good build:57.0.2978.0
Bad build:57.0.2979.0
 
Actual result.png
104 KB View Download
Actual result.mp4
1.0 MB View Download
Expected result.mp4
787 KB View Download
Cc: hdodda@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:57.0.2978.0 (revision : 442756)
Bad build:57.0.2979.0 (revision : 443120)
You are probably looking for a change made after 443055 (known good), but no later than 443056 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/ff407634505cc3c6203ed2f746000b6d6eea79b6..513f1f02c5c928367006c600cd1098f6315654ca

From the CL above, assigning the issue to the concern owner 

@cbiesinger- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2624143005

Note : As this is a recent regression , marking it as RB-Stable . Please feel free to edit/remove this.

Thanks!
Status: Started (was: Assigned)
This will be fixed by https://codereview.chromium.org/2684463002/
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c12965b9c068f00290a4c4ecce1cc9d404ec20a

commit 3c12965b9c068f00290a4c4ecce1cc9d404ec20a
Author: cbiesinger <cbiesinger@chromium.org>
Date: Tue Feb 07 20:03:27 2017

[css-flexbox] Clear override sizes when we're no longer a flex item

When we change to being absolutely positioned, we need to clear the override
size so as to avoid being affected by it.

R=eae@chromium.org
BUG= 687747 , 688938 , 688253 

Review-Url: https://codereview.chromium.org/2684463002
Cr-Commit-Position: refs/heads/master@{#448709}

[add] https://crrev.com/3c12965b9c068f00290a4c4ecce1cc9d404ec20a/third_party/WebKit/LayoutTests/css3/flexbox/change-flexitem-into-abspos.html
[modify] https://crrev.com/3c12965b9c068f00290a4c4ecce1cc9d404ec20a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Cc: pbomm...@chromium.org
Once we have enough coverage on Canary and Dev channel can you please request for merge to M57(Branch : 2987)
Status: Fixed (was: Started)
Yes, I'm requesting merge approval in  bug 688253 .
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/986dbbcbd724c5fb503b26ca44bec5b68dc3a88a

commit 986dbbcbd724c5fb503b26ca44bec5b68dc3a88a
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Wed Feb 08 21:14:43 2017

[css-flexbox] Clear override sizes when we're no longer a flex item

When we change to being absolutely positioned, we need to clear the override
size so as to avoid being affected by it.

R=eae@chromium.org
BUG= 687747 , 688938 , 688253 

Review-Url: https://codereview.chromium.org/2684463002
Cr-Commit-Position: refs/heads/master@{#448709}
(cherry picked from commit 3c12965b9c068f00290a4c4ecce1cc9d404ec20a)

Review-Url: https://codereview.chromium.org/2684073004 .
Cr-Commit-Position: refs/branch-heads/2987@{#395}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[add] https://crrev.com/986dbbcbd724c5fb503b26ca44bec5b68dc3a88a/third_party/WebKit/LayoutTests/css3/flexbox/change-flexitem-into-abspos.html
[modify] https://crrev.com/986dbbcbd724c5fb503b26ca44bec5b68dc3a88a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Labels: TE-Verified-57.0.2987.54 TE-Verified-M57
Verified the issue on windows 10, Mac 10.12.2 and Ubuntu 14.04 using chrome beta version #57.0.2987.54 as per comment #0

Observed that search icon did not get misplace and appeared properly as expected.

Attaching screen cast for reference.

Hence, adding the verified labels.

Thanks...!!
688938.mp4
9.4 MB View Download

Sign in to add a comment