New issue
Advanced search Search tips

Issue 688908 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 705662
issue 716649

Blocking:
issue 687462



Sign in to add a comment

Remove internal usage of -webkit-user-modify

Project Member Reported by xiaoche...@chromium.org, Feb 6 2017

Issue description

To deprecate -webkit-user-modify, we need to stop using it inside Chrome.

Code search result of webkit-user-modify:

https://cs.chromium.org/search/?q=webkit-user-modify+-file:layouttests+-file:test.cpp+-file:out/debug/gen&type=cs
 
Components: UI>Browser>WebUI Platform>Apps>FileManager Platform>DevTools Blink>CSS Platform>DevTools>Performance>Tracing
List of internal usage:

WebUI
- ui/webui/resources/css/tree.css

File Manager
- ui/file_manager/file_manager/foreground/css/tree.css

WebKit Core
- WebKit/Source/core/css/html.css
- WebKit/Source/core/css/themeInputMultipleFields.css

DevTools
- WebKit/Source/devtools/front_end/ui/filter.css
- WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
- WebKit/Source/devtools/front_end/ui/textPrompt.css
- WebKit/Source/devtools/front_end/ui/inspectorCommon.css
- WebKit/Source/devtools/front_end/sources/sourcesView.css
- WebKit/Source/devtools/front_end/elements/elementsPanel.css
- WebKit/Source/devtools/front_end/resources/resourcesPanel.css
- WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css

Tracing
- catapult/tracing/tracing/ui/scripting_control.html
- android_tools/sdk/platform-tools/systrace/systrace_trace_viewer.html

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/096255971db5c4a46640820fd617377fc3373652

commit 096255971db5c4a46640820fd617377fc3373652
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Feb 16 20:11:31 2017

Roll src/third_party/catapult/ d885da830..36a508280 (3 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d885da830d7a..36a50828018d

$ git log d885da830..36a508280 --date=short --no-merges --format='%ad %ae %s'
2017-02-16 benjhayden Add MergedRevisionInfo Diagnostic.
2017-02-16 xiaochengh [Tracing] Stop scripting_control.html from using -webkit-user-modify
2017-02-16 simonhatch Dashboard - Remove outlier detection from chart-container.html.

Created with:
  roll-dep src/third_party/catapult
BUG=688908

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2703443003
Cr-Commit-Position: refs/heads/master@{#451074}

[modify] https://crrev.com/096255971db5c4a46640820fd617377fc3373652/DEPS

Labels: Hotlist-CodeHealth Update-Monthly

Comment 4 by suzyh@chromium.org, Mar 27 2017

xiaochengh: Thanks for taking ownership of this removal. In Blink>CSS we prefer to have one component per bug for clearer responsibility. I would suggest filing one bug for each separate affected component, all marked as blocking issue 687462.
Blockedon: 705662
Components: -Blink>CSS
suzyh: Thanks for the advice. I filed issue 705662 for the removal from core/css.
Blockedon: 716649
Components: -Platform>DevTools
Labels: -Type-Bug Type-Task
Components: -Platform>DevTools>Performance>Tracing

Comment 9 by yosin@chromium.org, Oct 4 2017

Labels: Pri-3
Owner: ----
Status: Available (was: Assigned)
Unassign myself as I don't have any plan to work on it.
Labels: CrOS-FilesApp
Labels: -CrOS-FilesApp

Sign in to add a comment