Disambiguation popup - clarification of algorithm
Reported by
t...@wix.com,
Feb 5 2017
|
|||
Issue descriptionSteps to reproduce the problem: 1. Open http://tomenden.wixsite.com/blog-site 2. Click on one of the images What is the expected behavior? Link should open What went wrong? Disambiguation popup appears Did this work before? No Chrome version: 55.0.2883.91 Channel: n/a OS Version: 6.0.1 Flash Version: Shockwave Flash 24.0 r0 I am a developer, trying to understand why the disambiguation popup appears in the mentioned scenario. I can reproduce the problem consistently, but was unable to understand the source of the issue. I would appreciate if you could clarify the algorithm of the disambiguation popup - or point to where in the code I could find it. I searched the source code and was unable to find what I'm looking for. So far my findings are that disambiguation popup *should* appear when: 1. Two links are close to the tap area (what is defined as "close"?) 2. Link is small (what is "small"?) I was unable to understand clearly how this behaves with click event listeners, or with other events. Also, what is considered a potential clickable region per this algorithm? I noticed the feature is not limited to anchor tags, and also appears some times with forms. I appreciate your work on the project, and clarification on the algorithm would be invaluable to me. Thanks
,
Feb 7 2017
We are able to repro this issue on Chrome Stable:56.0.2924.87 Device: HuwaeiALE-L23/5.0.1 and Pixel/7.1 @ logcat http://go/chrome-androidlogs1/6/688853
,
Feb 7 2017
,
Feb 7 2017
The algorithm is in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/TouchDisambiguation.cpp > Also, what is considered a potential clickable region per this algorithm? The following code: bool Node::willRespondToMouseClickEvents() { if (isDisabledFormControl(this)) return false; document().updateStyleAndLayoutTree(); return hasEditableStyle(*this) || hasEventListeners(EventTypeNames::mouseup) || hasEventListeners(EventTypeNames::mousedown) || hasEventListeners(EventTypeNames::click) || hasEventListeners(EventTypeNames::DOMActivate); }
,
Mar 22 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rsgav...@chromium.org
, Feb 6 2017Labels: triage-te