New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 688778 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Link preload resources may bypass revalidation checks

Project Member Reported by y...@yoav.ws, Feb 5 2017

Issue description

Chrome Version: M58
OS: N/A

hiroshige@ pointed to me that that link preloads might be unnecessarily bypassing checks in ResourceFetcher::determineRevalidationPolicy.

There are two checks there for isPreloaded(). The first is conditional on the forPreload() flag, which indicates a speculative preload, and seems to be fine.

The second is only related to link preload preloaded resources. There are a few checks after that check, which might be important to revalidate even for link preloads:
* allowStoredCredentials match. We should make sure that matches for all requests.
* Vary header existence. I'd claim that this is important to revalidate only for cases where the request includes non default headers (headers set by XHR/fetch & client hints headers)

hiroshige@ - do you see any other checks that I missed and that should be applied to link preloads?

 

Comment 1 by addyo@chromium.org, Mar 29 2017

Cc: addyo@chromium.org

Sign in to add a comment